From ab2563ee448997b8276c1deeeafa913615ec1cd9 Mon Sep 17 00:00:00 2001 From: Chris Bracken Date: Thu, 8 Dec 2022 10:27:53 -0800 Subject: [PATCH] [embedder] Consistent naming for GL/Metal tests While I've sent a patch to mark the shell/platform/embedder/tests and fixtures directories as test exempt (since they are tests), by convention, tests should end in _unittests.* for C++ tests, and _test.* for Dart tests. This renames for consistency with other tests such as embedder_a11y_unittests.cc. Uncovered by https://github.com/flutter/engine/pull/38133 Related: https://github.com/flutter/cocoon/pull/2340 Issue: https://github.com/flutter/flutter/issues/116381 --- shell/platform/embedder/BUILD.gn | 4 ++-- .../{embedder_unittests_gl.cc => embedder_gl_unittests.cc} | 0 ...mbedder_unittests_metal.mm => embedder_metal_unittests.mm} | 0 3 files changed, 2 insertions(+), 2 deletions(-) rename shell/platform/embedder/tests/{embedder_unittests_gl.cc => embedder_gl_unittests.cc} (100%) rename shell/platform/embedder/tests/{embedder_unittests_metal.mm => embedder_metal_unittests.mm} (100%) diff --git a/shell/platform/embedder/BUILD.gn b/shell/platform/embedder/BUILD.gn index 83d62c610d1cb..491f6575bd428 100644 --- a/shell/platform/embedder/BUILD.gn +++ b/shell/platform/embedder/BUILD.gn @@ -317,11 +317,11 @@ if (enable_unittests) { deps = [ ":embedder_unittests_library" ] if (test_enable_gl) { - sources += [ "tests/embedder_unittests_gl.cc" ] + sources += [ "tests/embedder_gl_unittests.cc" ] } if (test_enable_metal) { - sources += [ "tests/embedder_unittests_metal.mm" ] + sources += [ "tests/embedder_metal_unittests.mm" ] } } diff --git a/shell/platform/embedder/tests/embedder_unittests_gl.cc b/shell/platform/embedder/tests/embedder_gl_unittests.cc similarity index 100% rename from shell/platform/embedder/tests/embedder_unittests_gl.cc rename to shell/platform/embedder/tests/embedder_gl_unittests.cc diff --git a/shell/platform/embedder/tests/embedder_unittests_metal.mm b/shell/platform/embedder/tests/embedder_metal_unittests.mm similarity index 100% rename from shell/platform/embedder/tests/embedder_unittests_metal.mm rename to shell/platform/embedder/tests/embedder_metal_unittests.mm