From effcf97a1f7c23c77c7cb17daf60a82ca856197a Mon Sep 17 00:00:00 2001 From: "auto-submit[bot]" <98614782+auto-submit[bot]@users.noreply.github.com> Date: Tue, 5 Mar 2024 23:47:35 +0000 Subject: [PATCH] Reverts "[Impeller] Enable depth buffer clipping & Stencil-then-Cover path rendering. (#51209)" (#51217) Reverts flutter/engine#51209 Initiated by: bdero Reason for reverting: Golden breakages on [engine roll](https://github.com/flutter/flutter/pull/144647) https://flutter-gold.skia.org/search?issue=144647&crs=github&patchsets=5&corpus=flutter Original PR Author: bdero Reviewed By: {jonahwilliams, chinmaygarde} This change reverts the following previous change: Original Description: Turn the page, wash your hands. Addresses the following issues: * https://github.com/flutter/flutter/issues/143077 * https://github.com/flutter/flutter/issues/137714 * https://github.com/flutter/flutter/issues/138460 * https://github.com/flutter/flutter/issues/123671 * https://github.com/flutter/flutter/issues/141961 * https://github.com/flutter/flutter/issues/134432 Previous attempt: - https://github.com/flutter/engine/pull/50856 - reverted with https://github.com/flutter/engine/pull/51191 - fixed with https://github.com/flutter/engine/pull/51198 --- impeller/entity/contents/content_context.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/impeller/entity/contents/content_context.h b/impeller/entity/contents/content_context.h index d38df9ae03b5a..6d4fc90298689 100644 --- a/impeller/entity/contents/content_context.h +++ b/impeller/entity/contents/content_context.h @@ -408,7 +408,7 @@ class ContentContext { /// // TODO(bdero): Remove this setting once StC is fully de-risked // https://github.com/flutter/flutter/issues/123671 - static constexpr bool kEnableStencilThenCover = true; + static constexpr bool kEnableStencilThenCover = false; #if IMPELLER_ENABLE_3D std::shared_ptr GetSceneContext() const;