Skip to content
This repository has been archived by the owner on Feb 25, 2025. It is now read-only.

Remove bringup from builds. #39605

Merged
merged 2 commits into from
Feb 14, 2023
Merged

Remove bringup from builds. #39605

merged 2 commits into from
Feb 14, 2023

Conversation

godofredoc
Copy link
Contributor

Windows arm, Linux Fuchsia FEMU and Linux Fuchsia FEMU arm64 have been passing consistently.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@godofredoc
Remove bringup from builds.
09e24da 
Windows arm, Linux Fuchsia FEMU and Linux Fuchsia FEMU arm64 have been
passing consistently.
jonahwilliams
jonahwilliams approved these changes Feb 14, 2023
View reviewed changes
Copy link
Member

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@godofredoc godofredoc added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 14, 2023
@auto-submit auto-submit bot merged commit 17ab09d into flutter:main Feb 14, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 14, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 14, 2023
@engine-flutter-autoroll
17ab09d38 Remove bringup from builds. (flutter/engine#39605)
0c693a4
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Feb 14, 2023
@engine-flutter-autoroll
Roll Flutter Engine from c4f51bc78644 to 17ab09d382e3 (5 revisions) (#…
6a94f25 
…120664)

* 3b5c47d4d Revert "[ios_platform_view] MaskView pool to reuse maskViews." (flutter/engine#39608)

* 170a4a31e Roll Skia from f27efe15433d to 38e363bbf0e4 (8 revisions) (flutter/engine#39611)

* 632b5985a Roll Fuchsia Mac SDK from 6hbPQq6ED0PkuQiKM... to OeUljRQOmJwgDhNOo... (flutter/engine#39610)

* 6a3aaefc0 Roll Fuchsia Linux SDK from 5b_BYTPWG1E7qx1I8... to mWwKhmxRlXNJATVmu... (flutter/engine#39613)

* 17ab09d38 Remove bringup from builds. (flutter/engine#39605)
0xZOne pushed a commit to 0xZOne/engine that referenced this pull request Feb 20, 2023
@godofredoc @0xZOne
Remove bringup from builds. (flutter#39605)
771d667 
* Remove bringup from builds.

Windows arm, Linux Fuchsia FEMU and Linux Fuchsia FEMU arm64 have been
passing consistently.

* Set fuchsia back to bringup.
@godofredoc godofredoc deleted the mark_bringup branch March 8, 2023 16:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jonahwilliams jonahwilliams jonahwilliams approved these changes

@zanderso zanderso Awaiting requested review from zanderso

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@godofredoc @jonahwilliams