Skip to content
This repository has been archived by the owner on Feb 25, 2025. It is now read-only.

Remove libpng dependency in the APNG decoder #39622

Merged
merged 1 commit into from
Feb 14, 2023
Merged

Remove libpng dependency in the APNG decoder #39622

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions lib/ui/painting/image_generator_apng.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@
#include <cstring>

#include "flutter/fml/logging.h"
#include "third_party/libpng/png.h"
#include "third_party/skia/include/codec/SkCodecAnimation.h"
#include "third_party/skia/include/core/SkAlphaType.h"
#include "third_party/skia/include/core/SkColorType.h"
Expand Down Expand Up @@ -202,8 +201,7 @@ std::unique_ptr<ImageGenerator> APNGImageGenerator::MakeFromData(
}
// Validate the full PNG signature.
const uint8_t* data_p = static_cast<const uint8_t*>(data.get()->data());
if (png_sig_cmp(static_cast<png_const_bytep>(data_p), 0,
sizeof(kPngSignature))) {
if (memcmp(data_p, kPngSignature, sizeof(kPngSignature))) {
return nullptr;
}

Expand Down