Skip to content
This repository has been archived by the owner on Feb 25, 2025. It is now read-only.

Add more info to malioc_diff.py output #39625

Merged
merged 1 commit into from
Feb 14, 2023
Merged

Add more info to malioc_diff.py output #39625

merged 1 commit into from
Feb 14, 2023

Conversation

zanderso
Copy link
Member

Fixes flutter/flutter#120401

New output looks like:

Changes found in shader flutter/impeller/entity/gles/advanced_blend.vert.gles on core Mali-G78:
In variant Position:
  has_stack_spilling: True <- before
  has_stack_spilling: False <- after
longest_path_cycles in variant Position
        arith_total arith_fma   arith_cvt   arith_sfu   load_store  texture     bound       
before  2.078125    2.078125    0.046875    0.000000    2.000000    0.000000    arith_fma
after   0.078125    0.078125    0.046875    0.000000    2.000000    0.000000    load_store


For a full report, run:
  $ malioc --vertex --core Mali-G78 out/host_debug_unopt/gen/flutter/impeller/entity/gles/advanced_blend.vert.gles

jonahwilliams
jonahwilliams approved these changes Feb 14, 2023
View reviewed changes
Copy link
Member

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Looks great :D

@zanderso zanderso added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 14, 2023
@auto-submit auto-submit bot merged commit cb53933 into flutter:main Feb 14, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 15, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 15, 2023
@engine-flutter-autoroll
cb5393336 Add more info to malioc_diff.py output (flutter/engine#39625)
15e3056
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 15, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 15, 2023
@engine-flutter-autoroll
cb5393336 Add more info to malioc_diff.py output (flutter/engine#39625)
d5e397b
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 15, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 15, 2023
@engine-flutter-autoroll
cb5393336 Add more info to malioc_diff.py output (flutter/engine#39625)
b891ebc
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 15, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 15, 2023
@engine-flutter-autoroll
cb5393336 Add more info to malioc_diff.py output (flutter/engine#39625)
05fa845
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 15, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 15, 2023
@engine-flutter-autoroll
cb5393336 Add more info to malioc_diff.py output (flutter/engine#39625)
3afdf03
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 15, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 15, 2023
@engine-flutter-autoroll
cb5393336 Add more info to malioc_diff.py output (flutter/engine#39625)
fbbac49
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 15, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 15, 2023
@engine-flutter-autoroll
cb5393336 Add more info to malioc_diff.py output (flutter/engine#39625)
6b96bfc
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 15, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 15, 2023
@engine-flutter-autoroll
cb5393336 Add more info to malioc_diff.py output (flutter/engine#39625)
8d79917
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Feb 15, 2023
@engine-flutter-autoroll
Roll Flutter Engine from d860892528ff to 44e36c9c0d73 (20 revisions) (#…
911b137 
…120761)

* ab2dec516 Roll Skia from 8de7f68a3661 to 67a8177742e6 (4 revisions) (flutter/engine#39623)

* a7ec1e50f Remove libpng dependency in the APNG decoder (flutter/engine#39622)

* cb5393336 Add more info to malioc_diff.py output (flutter/engine#39625)

* 60c199501 Roll Dart SDK from ea59504416a8 to 22ad11262460 (2 revisions) (flutter/engine#39624)

* b1f76fbb0 [Impeller] Avoid stringstream usage in CreateUniformMemberKey (flutter/engine#39606)

* a85220d2f Fix a flake in EmbedderTest.CompositorRenderTargetsNotRecycledWhenAvoidsCacheSet (flutter/engine#39596)

* 3141b116d [impeller] Refactored backend specific feature checks to capabilities (flutter/engine#39598)

* bf667254f [impellerc] Generate GLSL output for the runtime-stage-gles target (flutter/engine#39602)

* 57e83aa16 [Impeller] Special case color filter in tiled texture. (flutter/engine#39445)

* e1325a9de Roll Skia from 67a8177742e6 to a3fe5233eb10 (9 revisions) (flutter/engine#39627)

* 9f2c4db50 Add app anatomy diagram (flutter/engine#39628)

* e8c14e436 Roll Fuchsia Linux SDK from mWwKhmxRlXNJATVmu... to A15Lg2MzGSkbj33mo... (flutter/engine#39631)

* 9bd50b706 [Impeller] read from framebuffer for advanced blends on iOS. (flutter/engine#39567)

* 66715c928 Fix build output path of the malioc core list (flutter/engine#39629)

* 727500b12 Roll Skia from a3fe5233eb10 to b7508e2f2577 (3 revisions) (flutter/engine#39634)

* f193de9cc [Impeller] Make RenderTarget::CreateOffscreen utilities have a stencil by default (flutter/engine#39636)

* 76b51e33a Roll Skia from b7508e2f2577 to 5974e36ea190 (4 revisions) (flutter/engine#39639)

* aba44ff0b Roll Dart SDK from 22ad11262460 to 1dc26efa3c4c (1 revision) (flutter/engine#39640)

* 657102f87 Roll Fuchsia Mac SDK from EFcCpAxOuQllDqP0F... to jsnm3dngrd9MveHrB... (flutter/engine#39641)

* 44e36c9c0 Roll Skia from 5974e36ea190 to 2a7644cf4bd7 (1 revision) (flutter/engine#39642)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jonahwilliams jonahwilliams jonahwilliams approved these changes

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App
Projects
None yet
Milestone
No milestone
2 participants
@zanderso @jonahwilliams