This repository has been archived by the owner on Feb 25, 2025. It is now read-only.
Revert "Roll Dart SDK from 3d13dbfb3284 to 764bdb7d0344 (1 revision) (#52051)" #52060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lutter#52051)" This reverts commit b462350.
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
whesse
approved these changes
Apr 11, 2024
zanderso
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 11, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 11, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Apr 11, 2024
…146645) flutter/engine@d8560d4...98a8ad1 2024-04-11 [email protected] [et] Correctly plumb usage line length limit (flutter/engine#52039) 2024-04-11 [email protected] Revert "Roll Dart SDK from 3d13dbfb3284 to 764bdb7d0344 (1 revision) (#52051)" (flutter/engine#52060) 2024-04-11 [email protected] Composite multiple layers in Windows software rendering (flutter/engine#51759) 2024-04-11 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Roll Dart SDK from 764bdb7d0344 to 0219e897c6ac (1 revision) (#52053)" (flutter/engine#52058) 2024-04-11 [email protected] Roll Skia from 2a2fe4303507 to 1dc3c2c1b550 (1 revision) (flutter/engine#52055) 2024-04-11 [email protected] Roll Skia from aa30d76a345f to 2a2fe4303507 (1 revision) (flutter/engine#52054) 2024-04-11 [email protected] Roll Dart SDK from 764bdb7d0344 to 0219e897c6ac (1 revision) (flutter/engine#52053) 2024-04-11 [email protected] Roll Skia from 29f0c9d84e70 to aa30d76a345f (1 revision) (flutter/engine#52052) 2024-04-11 [email protected] Roll Dart SDK from 3d13dbfb3284 to 764bdb7d0344 (1 revision) (flutter/engine#52051) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
gilnobrega
pushed a commit
to gilnobrega/flutter
that referenced
this pull request
Apr 22, 2024
…lutter#146645) flutter/engine@d8560d4...98a8ad1 2024-04-11 [email protected] [et] Correctly plumb usage line length limit (flutter/engine#52039) 2024-04-11 [email protected] Revert "Roll Dart SDK from 3d13dbfb3284 to 764bdb7d0344 (1 revision) (flutter#52051)" (flutter/engine#52060) 2024-04-11 [email protected] Composite multiple layers in Windows software rendering (flutter/engine#51759) 2024-04-11 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Roll Dart SDK from 764bdb7d0344 to 0219e897c6ac (1 revision) (flutter#52053)" (flutter/engine#52058) 2024-04-11 [email protected] Roll Skia from 2a2fe4303507 to 1dc3c2c1b550 (1 revision) (flutter/engine#52055) 2024-04-11 [email protected] Roll Skia from aa30d76a345f to 2a2fe4303507 (1 revision) (flutter/engine#52054) 2024-04-11 [email protected] Roll Dart SDK from 764bdb7d0344 to 0219e897c6ac (1 revision) (flutter/engine#52053) 2024-04-11 [email protected] Roll Skia from 29f0c9d84e70 to aa30d76a345f (1 revision) (flutter/engine#52052) 2024-04-11 [email protected] Roll Dart SDK from 3d13dbfb3284 to 764bdb7d0344 (1 revision) (flutter/engine#52051) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit b462350.
Reverting for regression in
dart fixin https://dart.googlesource.com/sdk.git/+/e9b5a0166300800e860de1a61294c5f24b4507b3