This repository has been archived by the owner on Feb 25, 2025. It is now read-only.
Various documentation improvements (#52600) #52623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
From PR triage: @Hixie are you still working on this? |
|
yup, just didn't want to land this when i wasn't around :-) |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 10, 2024
zanderso
reviewed
May 10, 2024
| /// | ||
| /// ```dart | ||
| /// // Matrix4's constructor arguments are in column-major order. | ||
| /// Matrix4(rst.scos, rst.ssin, 0, 0, |
There was a problem hiding this comment.
snippet analysis is sad that rst isn't initialized.
There was a problem hiding this comment.
|
Reason for revert: Snippet analysis failure blocking the roll to the framework. |
zanderso
added
the
revert
|
The revert bot appears to be down. I'll kick off a manual revert. |
zanderso
added a commit
that referenced
this pull request
May 10, 2024
zanderso
added a commit
that referenced
this pull request
May 10, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 10, 2024
zanderso
pushed a commit
to flutter/flutter
that referenced
this pull request
May 10, 2024
…148137) flutter/engine@c0917b1...1ccd0c3 2024-05-10 [email protected] Fixed constness of display list storage. (flutter/engine#52705) 2024-05-10 [email protected] Revert "Various documentation improvements (#52600)" (flutter/engine#52709) 2024-05-10 [email protected] Manual roll Dart SDK from b7cad2edae4b to 01121c008f4d (3 revisions) (flutter/engine#52706) 2024-05-10 [email protected] [iOS] Fix App crash when use WebView with iOS VoiceOver (flutter/engine#52484) 2024-05-09 [email protected] Various documentation improvements (#52600) (flutter/engine#52623) 2024-05-09 [email protected] [web] scale semantic text elements to match the desired focus ring size (flutter/engine#52586) 2024-05-09 [email protected] [Impeller] Adds impeller display list golden tests (flutter/engine#52690) 2024-05-09 [email protected] Roll buildroot to 70a42312a688 (flutter/engine#52675) 2024-05-09 [email protected] When `et` is not attached to a terminal, still split lines for status updates. (flutter/engine#52681) 2024-05-09 [email protected] updated analysis exclusion (flutter/engine#52699) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
|
Unable to create the revert pull request due to ProcessException: Standard out nothing to commit, working tree clean |
auto-submit
bot
removed
the
revert
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a reland of #52600 which was reverted in #52607 due to a typo.