This repository has been archived by the owner on Feb 25, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6k
Roll Skia from 3f4c5038da37 to e26d9e5d356f (18 revisions) #52928
Merged
auto-submit
merged 1 commit into
flutter:main
from
skia-flutter-autoroll:skia-flutter-autoroll-1d1ef4c3-95a8-448e-af20-ddfc70146702-1716219589
May 20, 2024
Merged
Roll Skia from 3f4c5038da37 to e26d9e5d356f (18 revisions) #52928
auto-submit
merged 1 commit into
flutter:main
from
skia-flutter-autoroll:skia-flutter-autoroll-1d1ef4c3-95a8-448e-af20-ddfc70146702-1716219589
May 20, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://skia.googlesource.com/skia.git/+log/3f4c5038da37..e26d9e5d356f 2024-05-20 [email protected] [Graphite] Add support for labels on user created SkSurfaces. 2024-05-20 [email protected] Revert "Reland "GraphiteDawn: use dawn's LoadResolveTexture extension."" 2024-05-20 [email protected] Add check when x is 0 in sweep gradient to avoid UB. 2024-05-20 [email protected] Make skparagraph Bazel target naming consistent 2024-05-20 [email protected] Roll vulkan-deps from fd6f3c04f129 to de5559d9b295 (1 revision) 2024-05-20 [email protected] [paragraph] Make tests less likely to crash 2024-05-20 [email protected] Roll SK Tool from 1e93252a646d to 6f8e6e4009f3 2024-05-20 [email protected] Roll Skia Infra from 6da3279dd380 to 1e93252a646d (3 revisions) 2024-05-20 [email protected] Roll Dawn from 8122e7e3d144 to e3a4352eecab (22 revisions) 2024-05-20 [email protected] Roll vulkan-deps from 8a4a82565901 to fd6f3c04f129 (1 revision) 2024-05-19 [email protected] Roll SK Tool from 31d02bca8cff to 1e93252a646d 2024-05-19 [email protected] Roll vulkan-deps from 734bd27673a1 to 8a4a82565901 (1 revision) 2024-05-18 [email protected] Roll vulkan-deps from b2bda3989476 to 734bd27673a1 (1 revision) 2024-05-17 [email protected] Roll vulkan-deps from 30a48b37b02b to b2bda3989476 (1 revision) 2024-05-17 [email protected] Add PDF module 2024-05-17 [email protected] Revert "[Fontations-backend] Hook up Skrifa hinting support" 2024-05-17 [email protected] [graphite] Modify MatrixConvolutionImageFilter's SkSL generation 2024-05-17 [email protected] Add onAsLuminance to SkLocalMatrixShader. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-flutter-autoroll Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
fluttergithubbot
approved these changes
May 20, 2024
Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change). If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review. |
SkiaGold diff looks intentional as part of https://skia.googlesource.com/skia.git/+/b2b10fc9c41af6eadc3aa9bf7a36d48d12631f3d. I'm going to accept the diff, but @lhkbob to confirm, just in case. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 20, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 20, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
May 20, 2024
…148700) flutter/engine@c6fecf6...a8fb9da 2024-05-20 [email protected] Roll Skia from e26d9e5d356f to 0b8d8ce44d1f (4 revisions) (flutter/engine#52929) 2024-05-20 [email protected] Roll Skia from 3f4c5038da37 to e26d9e5d356f (18 revisions) (flutter/engine#52928) 2024-05-20 [email protected] Manual roll Dart SDK from 3c8718d827b5 to 54c384453207 (2 revisions) (flutter/engine#52927) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://skia.googlesource.com/skia.git/+log/3f4c5038da37..e26d9e5d356f
2024-05-20 [email protected] [Graphite] Add support for labels on user created SkSurfaces.
2024-05-20 [email protected] Revert "Reland "GraphiteDawn: use dawn's LoadResolveTexture extension.""
2024-05-20 [email protected] Add check when x is 0 in sweep gradient to avoid UB.
2024-05-20 [email protected] Make skparagraph Bazel target naming consistent
2024-05-20 [email protected] Roll vulkan-deps from fd6f3c04f129 to de5559d9b295 (1 revision)
2024-05-20 [email protected] [paragraph] Make tests less likely to crash
2024-05-20 [email protected] Roll SK Tool from 1e93252a646d to 6f8e6e4009f3
2024-05-20 [email protected] Roll Skia Infra from 6da3279dd380 to 1e93252a646d (3 revisions)
2024-05-20 [email protected] Roll Dawn from 8122e7e3d144 to e3a4352eecab (22 revisions)
2024-05-20 [email protected] Roll vulkan-deps from 8a4a82565901 to fd6f3c04f129 (1 revision)
2024-05-19 [email protected] Roll SK Tool from 31d02bca8cff to 1e93252a646d
2024-05-19 [email protected] Roll vulkan-deps from 734bd27673a1 to 8a4a82565901 (1 revision)
2024-05-18 [email protected] Roll vulkan-deps from b2bda3989476 to 734bd27673a1 (1 revision)
2024-05-17 [email protected] Roll vulkan-deps from 30a48b37b02b to b2bda3989476 (1 revision)
2024-05-17 [email protected] Add PDF module
2024-05-17 [email protected] Revert "[Fontations-backend] Hook up Skrifa hinting support"
2024-05-17 [email protected] [graphite] Modify MatrixConvolutionImageFilter's SkSL generation
2024-05-17 [email protected] Add onAsLuminance to SkLocalMatrixShader.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md