[Impeller] move Aiks path unittests to DL #53799
Conversation
|
Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change). If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review. |
|
Golden file changes are available for triage from new commit, Click here to view. |
|
This one still has some questionable golden changes. Will investigate tomorrow. |
|
For the I actually think the before image isn't perfectly correct either: The top end should be perfectly horizontal. I suspect the test change is just making the same already-visible issue more obvious. |
|
Filled flutter/flutter#151694 |
jonahwilliams
added
the
autosubmit
…151698) flutter/engine@b555f8f...d4df563 2024-07-12 [email protected] [Impeller] move Aiks path unittests to DL (flutter/engine#53799) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Move more impeller tests to display list format. This allows our integration tests to also test the display list -> aiks interop and be future compatible with the new canvas backend that removes AIKS.
Part of flutter/flutter#142054