Skip to content
This repository has been archived by the owner on Feb 25, 2025. It is now read-only.

Align tools/android_sdk/packages.txt with what is uploaded to CIPD #53921

Merged
merged 1 commit into from
Jul 16, 2024

Conversation

gmackall
Copy link
Member

@gmackall gmackall commented Jul 16, 2024

This file should always be kept in sync with what we are actually using, but it seems to currently be out of sync.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@gmackall gmackall marked this pull request as ready for review July 16, 2024 00:03
Copy link
Contributor

@camsim99 camsim99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gmackall gmackall added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 16, 2024
@auto-submit auto-submit bot merged commit c5f141e into flutter:main Jul 16, 2024
29 checks passed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 16, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 16, 2024
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Jul 16, 2024
…151802)

flutter/engine@f1363fb...235e67f

2024-07-16 [email protected] Roll Skia from d4acfbe0b001 to c91cad775529 (1 revision) (flutter/engine#53924)
2024-07-16 [email protected] Align `tools/android_sdk/packages.txt` with what is uploaded to CIPD (flutter/engine#53921)
2024-07-15 [email protected] Roll Skia from 6347d8255f83 to d4acfbe0b001 (3 revisions) (flutter/engine#53919)
2024-07-15 [email protected] Move images to flutter/assets-for-api-docs (flutter/engine#53917)
2024-07-15 [email protected] Roll Skia from b63d0290b826 to 6347d8255f83 (5 revisions) (flutter/engine#53916)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
TytaniumDev pushed a commit to TytaniumDev/flutter that referenced this pull request Aug 7, 2024
…lutter#151802)

flutter/engine@f1363fb...235e67f

2024-07-16 [email protected] Roll Skia from d4acfbe0b001 to c91cad775529 (1 revision) (flutter/engine#53924)
2024-07-16 [email protected] Align `tools/android_sdk/packages.txt` with what is uploaded to CIPD (flutter/engine#53921)
2024-07-15 [email protected] Roll Skia from 6347d8255f83 to d4acfbe0b001 (3 revisions) (flutter/engine#53919)
2024-07-15 [email protected] Move images to flutter/assets-for-api-docs (flutter/engine#53917)
2024-07-15 [email protected] Roll Skia from b63d0290b826 to 6347d8255f83 (5 revisions) (flutter/engine#53916)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
autosubmit Merge PR when tree becomes green via auto submit App
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants