Skip to content

Commit

Permalink
[google_maps_flutter] removed old overrides (#4679)
Browse files Browse the repository at this point in the history
Removed 2 overrides with the comment
```
// TODO(mklim): Remove this empty override once #40126 is fixed in stable.
```
As the issue was fixed in 2019

Related to #131791
  • Loading branch information
mishapark authored Aug 12, 2023
1 parent ea49db5 commit 08080ab
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 17 deletions.
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
## NEXT

## 2.4.16
* Removes old empty override methods.
* Fixes unawaited_futures violations.

## 2.4.15
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -604,20 +604,6 @@ private void setGoogleMapListener(@Nullable GoogleMapListener listener) {
googleMap.setOnMapLongClickListener(listener);
}

// @Override
// The minimum supported version of Flutter doesn't have this method on the PlatformView interface, but the maximum
// does. This will override it when available even with the annotation commented out.
public void onInputConnectionLocked() {
// TODO(mklim): Remove this empty override once https://github.com/flutter/flutter/issues/40126 is fixed in stable.
}

// @Override
// The minimum supported version of Flutter doesn't have this method on the PlatformView interface, but the maximum
// does. This will override it when available even with the annotation commented out.
public void onInputConnectionUnlocked() {
// TODO(mklim): Remove this empty override once https://github.com/flutter/flutter/issues/40126 is fixed in stable.
}

// DefaultLifecycleObserver

@Override
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ name: google_maps_flutter_android
description: Android implementation of the google_maps_flutter plugin.
repository: https://github.com/flutter/packages/tree/main/packages/google_maps_flutter/google_maps_flutter_android
issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+maps%22
version: 2.4.15
version: 2.4.16

environment:
sdk: ">=2.18.0 <4.0.0"
Expand Down

0 comments on commit 08080ab

Please sign in to comment.