-
Notifications
You must be signed in to change notification settings - Fork 28k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Android] Autofill from saved credentials doesn't work #137760
Comments
Hi @TatsuUkraine. When you setup details, have you also set those up in the system "autofill service" settings and provide relevant information to the autofill service for it to work ? |
@dam-ease sorry, not sure that I understood the question( for this example I didn't do any native configuration for Android, basically this issue appears only when app looses focus either because of biometric auth or because you go into the password manager. If biometric auth is not requested, and you using password suggestions from the keyboard quick action - all works fine |
@dam-ease I already replied😅 |
@dam-ease I added video to the description to better explain what is going on. On a video when screen goes black - it asks for biometric verification. On a video there are 3 attempts:
Autofill works only when app doesn't go to background (3rd try) |
I guess the time you replied and the time the label updated were the same. Screen.Recording.2023-11-03.at.17.55.12.mov |
It seems biometric verification doesn't affect behavior a lot. If I disable biometric check for password usages only one difference is that there is no scenario 2 (from my prev comment). So it seems autofill just stops working when the app goes to background and the text field loses focus, either because of password manager bottom sheet or because of biometric check screen-20231103-160500.2.mp4Also, one note, I'm not entirely sure, since I didn't check this explicitly, but I think all was working in prev stable release |
I am seeing this same behavior while using 1password. Once the manager is unlocked, 1password can fill as expected from the small "account choosing" modal, but still cannot fill from the "open 1password" option. It seems this happens any time my app is pushed to the background by the password manager. IF I force the focusNode for the username field to never loose focus by requesting focus when the focusNode is not in focus, it will autofill. It seems like the password manager does not/cannot regain focus on the textfield before it attempts to push the username/password text.
Edit: Screen_Recording_20231120_152145.mp4 |
I started to notice this issue once my device got Android 14 update. on Android 13 it was working fine. |
UPDATE: On version 3.22.0 works fine |
Looks like the first bad commit is 04e284a. The issue went away when the commit was reverted. |
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
To unpack this a bit: That engine commit was reverted in flutter/engine@500ae6c. That revert rolled into flutter/flutter in commit d35c08e, which was part of Flutter 3.22.0 but not 3.19.6 (the previous release). |
We're facing the same issue with password autofill. Using Flutter 3.22.1 |
All works fine for me on Android after update to 3.22.1. Fields aren't loosing focus during biometric verification in password manager. Login and password prefilled correctly in the form |
@LongCatIsLooong I don't know why bot reopened the issue, sorry 😅 |
Might be a sign ! 😄 On Android Username is not saved to Google Password Manager for me, only suggested password While on iOS existing password autofill does not fill the fields anymore (but I will investigate and open an issue) |
Jup, works for me on android, but I still have the same old issues on iOS build |
We are still running the exact same issue on iOS running Flutter 3.22.2. I noticed that after returning to the app, the username/password fields are unfocused. As soon as I manually tap on them to regain focus, the autofill values from the password manager (1Password in my case) are entered correctly. Thus this feels like the issue as explained above, where the fields losing focus on the app being sent to the background being the issue. |
@alarkirikal There is an ongoing issue for iOS autofill. Based on discussion looks like it will be fixed in the next stable release |
Just a bit later found that issue as well - wasn't that obvious to find at first glance due to its Closed status. But thank you for confirming. |
This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of |
Hi, is there any update on this? I can reproduce the issue using the example code on Flutter version 3.24.3. I tried the workaround and it works perfectly (android), but I also see some people saying that on version 3.22.1 it works now, but not for me (I also tried with this specific version). Thanks |
Google Password Manager autofill generates this error on password save: ` ` |
Hi! I have the same issue on the web app. |
Hi, are you using Windows Hello to protect the credentials on Chrome ? |
No. I don't. Actually my comment is related to password manager in chrome on Android that has exactly the same behaviour as described in the ticket description. Chrome for desktop, safary on iphone works as expected. |
Is there an existing issue for this?
Steps to reproduce
Device for testing
Google Pixel 7 pro, Android 14 (34)
Expected results
Form prepopulates with the selected username/password combination
Actual results
Input loses focus and nothing happens.
Form can be prepopulated only if login/password combination is selected from Keyboard quick actions and no biometric check is requested
Code sample
Code sample (very simple autofillgroup with 2 inputs)
Screenshots or Video
Video
screen-20231103-102820.2.mp4
Logs
Logs
Flutter Doctor output
Doctor output
The text was updated successfully, but these errors were encountered: