Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Google Maps Plugin add InfoWindowClickListener and Resize #17730

Closed
gerryhigh opened this issue May 18, 2018 · 6 comments
Closed
Labels
c: new feature Nothing broken; request for a new capability p: maps Google Maps plugin package flutter/packages repository. See also p: labels.

Comments

@gerryhigh
Copy link

I need the ability to get notified when a user clicks on an info window in the package https://github.com/flutter/plugins/tree/master/packages/google_maps_flutter. Currently it appears you can only get an event when they click on the marker and not the info window. In my kotlin app I've done it via setting setOnInfoWindowClickListener on the map.

Also, in order to handle rotation events I need the ability to resize the map. Currently it appears that there is only the ability to set the size at construction time.

@mravn-google @mit-mit

Thanks!

@gerryhigh
Copy link
Author

FWIW I've implemented the setOnInfoWindowClickListener to get callbacks in flutter when the user clicks on the Info Window. That was pretty trivial. Eventually I'll post the code/PR; ping me in the interim if interested.

I'm currently working on the map resize feature.

@mravn-google
Copy link
Contributor

PRs are most welcome, especially for additions to the GoogleMapController API such as responding to extra touch events.

For PRs that make platform overlays work in more situations, please keep it as simple as possible. Platform overlays are not the long-term solution to integrating Google Maps, and we'd very much like to avoid throwing a lot of effort and complex code into this dead end.

@gerryhigh
Copy link
Author

@mravn-google @mit-mit Any idea when this pull request will get looked at? flutter/plugins#594

@mravn-google
Copy link
Contributor

@gerryhigh Sorry, I somehow overlooked this PR.

@zoechi zoechi added c: new feature Nothing broken; request for a new capability plugin labels Aug 26, 2018
@zoechi zoechi added the p: maps Google Maps plugin label Jan 8, 2019
@iskakaushik
Copy link
Contributor

Looks like this has merged.

@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 30, 2021
@flutter-triage-bot flutter-triage-bot bot added the package flutter/packages repository. See also p: labels. label Jul 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
c: new feature Nothing broken; request for a new capability p: maps Google Maps plugin package flutter/packages repository. See also p: labels.
Projects
None yet
Development

No branches or pull requests

4 participants