Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[flutter_tools] IDE plugin validators should be deprecated #61246

Open
christopherfujino opened this issue Jul 10, 2020 · 6 comments
Open

[flutter_tools] IDE plugin validators should be deprecated #61246

christopherfujino opened this issue Jul 10, 2020 · 6 comments
Labels
c: proposal A detailed proposal for a change to Flutter P2 Important issues not at the top of the work list team-tool Owned by Flutter Tool team tool Affects the "flutter" command-line tool. See also t: labels. triaged-tool Triaged by Flutter Tool team

Comments

@christopherfujino
Copy link
Member

christopherfujino commented Jul 10, 2020

Supporting the filepaths to the android studio plugins is a moving target, that has proven difficult to keep up to date. In addition, the warning makes Flutter users think that the SDK will not function properly, when this is a completely informational warning; in other words, Flutter does not directly use the IDE plugins, so doctor failing to detect them does not affect any behavior (it's just annoying).

@eckhartcke
Copy link

As a Flutter developer, I would advocate against this change unless some other warning is provided when the plugins are failing. While I acknowledge the premise that it doesn't compromise the generation of an app, it DOES compromise my productivity in the extreme. So much so that I downgraded Android Studio so I can have the benefit of the plugins while this gets sorted out.

To the Flutter team: Rest assured that I emphatically endorse both Flutter and the people who work on it. Just please be mindful of the entire developer experience as you make decisions that affect the community. Please don't deprecate this validity check without giving visibility to the broken-ness of these plugins in some other way.

To be clear to anyone not close to the issue, the warning is/was correct; The plugins were not working. I'm not arguing so much against this specific change, as FOR the addition of some developer alert that a previously working functionality is broken. With appropriate observability, I can immediately move to making a decision about how it affects me rather than wasting a lot of time sleuthing out that something is not working.

Thanks for all you do. Flutter is epic.

@christopherfujino
Copy link
Member Author

To be clear to anyone not close to the issue, the warning is/was correct; The plugins were not working. I'm not arguing so much against this specific change, as FOR the addition of some developer alert that a previously working functionality is broken. With appropriate observability, I can immediately move to making a decision about how it affects me rather than wasting a lot of time sleuthing out that something is not working.

I'm not familiar with the issue you are referring to, but it sounds like this is a new feature request. Note that the Flutter doctor plugin validators do NOT validate the plugin works, but only that they exist on disk. I'm not sure how we would validate that installed plugins are working.

@yashtibrewal
Copy link

yashtibrewal commented Jan 12, 2021

Isn't there a way we can manually give the paths like we can configure the paths w.r.t android studio and android SDK? ( provided there is a way to get the path to those plugins...) will this not solve the issue for both arguments, for and against?

@christopherfujino
Copy link
Member Author

Isn't there a way we can manually give the paths like we can configure the paths w.r.t android studio and android SDK? ( provided there is a way to get the path to those plugins...) will this not solve the issue for both arguments, for and against?

If you already know exactly where your plugin is, presumably you know that it is present, and thus you don't need the validator, right? We want to deprecate the plugin validators so that new users no longer get false negatives, where they have a working IDE setup but think they need to fix it.

@kf6gpe
Copy link
Contributor

kf6gpe commented Jan 14, 2021

/cc @jonahwilliams Any thoughts here? It sounds it's working but generating warnings. It's been reported by front-line triage to be increasingly an issue for our users.

@yashtibrewal
Copy link

Isn't there a way we can manually give the paths like we can configure the paths w.r.t android studio and android SDK? ( provided there is a way to get the path to those plugins...) will this not solve the issue for both arguments, for and against?

If you already know exactly where your plugin is, presumably you know that it is present, and thus you don't need the validator, right? We want to deprecate the plugin validators so that new users no longer get false negatives, where they have a working IDE setup but think they need to fix it.

Hi,
Yes, I agree with your point,
I am new to Dart and Flutter myself, but image this.
They remove the validator
I am not aware of it
and I go down a path less traveled?
I got to know about those plugins only after reading in detail why we are getting those errors/warnings.
Yes, they are annoying, but they do nudge the new users to have the plugins.
An alternative would be to have a separate icon instead of a red wrong cross, something which tells it's optional but preferrable.
I partially support your point to remove ( I would suggest, move them to warning or suggestion topic under the logs generated by flutter doctor.

@darshankawar darshankawar added the c: proposal A detailed proposal for a change to Flutter label Oct 11, 2022
@flutter-triage-bot flutter-triage-bot bot added the team-tool Owned by Flutter Tool team label Jul 8, 2023
@christopherfujino christopherfujino added triaged-tool Triaged by Flutter Tool team P2 Important issues not at the top of the work list labels Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: proposal A detailed proposal for a change to Flutter P2 Important issues not at the top of the work list team-tool Owned by Flutter Tool team tool Affects the "flutter" command-line tool. See also t: labels. triaged-tool Triaged by Flutter Tool team
Projects
None yet
Development

No branches or pull requests

7 participants