-
Notifications
You must be signed in to change notification settings - Fork 3.1k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
make FakeView not send Scene and semantics to the engine (#138849)
`FakeView` wraps the same underlying `FlutterView`. Sending semantics updates and Scene objects from multiple fake views into the same engine `FlutterView` violates contracts with the engine. This PR stubs out `render` and `updateSemantics` methods in `FakeView` classes to prevent that. This unblocks flutter/engine#48251, which implements multi-view semantics for web.
- Loading branch information
Showing
7 changed files
with
76 additions
and
60 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,33 @@ | ||
// Copyright 2014 The Flutter Authors. All rights reserved. | ||
// Use of this source code is governed by a BSD-style license that can be | ||
// found in the LICENSE file. | ||
|
||
import 'dart:ui'; | ||
|
||
import 'package:flutter_test/flutter_test.dart'; | ||
|
||
class FakeView extends TestFlutterView { | ||
FakeView(FlutterView view, { this.viewId = 100 }) : super( | ||
view: view, | ||
platformDispatcher: view.platformDispatcher as TestPlatformDispatcher, | ||
display: view.display as TestDisplay, | ||
); | ||
|
||
@override | ||
final int viewId; | ||
|
||
@override | ||
void render(Scene scene) { | ||
// Do not render the scene in the engine. The engine only observes one | ||
// instance of FlutterView (the _view), and it is generally expected that | ||
// the framework will render no more than one `Scene` per frame. | ||
} | ||
|
||
@override | ||
void updateSemantics(SemanticsUpdate update) { | ||
// Do not send the update to the engine. The engine only observes one | ||
// instance of FlutterView (the _view). Sending semantic updates meant for | ||
// different views to the same engine view does not work as the updates do | ||
// not produce consistent semantics trees. | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,33 @@ | ||
// Copyright 2014 The Flutter Authors. All rights reserved. | ||
// Use of this source code is governed by a BSD-style license that can be | ||
// found in the LICENSE file. | ||
|
||
import 'dart:ui'; | ||
|
||
import 'package:flutter_test/flutter_test.dart'; | ||
|
||
class FakeView extends TestFlutterView { | ||
FakeView(FlutterView view, { this.viewId = 100 }) : super( | ||
view: view, | ||
platformDispatcher: view.platformDispatcher as TestPlatformDispatcher, | ||
display: view.display as TestDisplay, | ||
); | ||
|
||
@override | ||
final int viewId; | ||
|
||
@override | ||
void render(Scene scene) { | ||
// Do not render the scene in the engine. The engine only observes one | ||
// instance of FlutterView (the _view), and it is generally expected that | ||
// the framework will render no more than one `Scene` per frame. | ||
} | ||
|
||
@override | ||
void updateSemantics(SemanticsUpdate update) { | ||
// Do not send the update to the engine. The engine only observes one | ||
// instance of FlutterView (the _view). Sending semantic updates meant for | ||
// different views to the same engine view does not work as the updates do | ||
// not produce consistent semantics trees. | ||
} | ||
} |