Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[camera] CameraPlatform.createCameraWithSettings #3587

Closed
wants to merge 0 commits into from

Conversation

PROGrand
Copy link
Contributor

@PROGrand PROGrand commented Mar 29, 2023

This is the platform-interface part of camera PR #3586.

Enabling fps and bitrate control of recorded video.
Allow users to more control over recorded video size.
CameraPlatform.createCameraWithSettings is added, leaving original CameraPlatform.createCamera commented as deprecated. So this is not breaking change.
Tested on a set of mobile devices.
Web support depends on browser (perfect with Firefox).

@PROGrand PROGrand requested a review from bparrishMines as a code owner March 29, 2023 23:06
@PROGrand PROGrand force-pushed the camera-platform-interface branch from 869b787 to 35f4799 Compare March 29, 2023 23:07
@PROGrand PROGrand changed the title CameraPlatform.createCameraWithSettings [camera] CameraPlatform.createCameraWithSettings Mar 29, 2023
@PROGrand PROGrand force-pushed the camera-platform-interface branch 2 times, most recently from dea45fe to 1739b1a Compare March 30, 2023 21:53
@PROGrand PROGrand requested a review from camsim99 as a code owner April 1, 2023 00:15
@PROGrand PROGrand closed this Apr 1, 2023
@PROGrand PROGrand force-pushed the camera-platform-interface branch from 0126bd2 to 6502403 Compare April 1, 2023 08:34
@github-actions github-actions bot removed the p: camera label Apr 1, 2023
@PROGrand PROGrand deleted the camera-platform-interface branch April 1, 2023 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant