From 50789bb5eacfcc326186ab672d005847cddf7794 Mon Sep 17 00:00:00 2001 From: Reid Baker Date: Fri, 12 May 2023 12:28:22 -0400 Subject: [PATCH 1/2] Update build.gradle with a comment explaining version --- .../camera/camera_android_camerax/example/android/build.gradle | 3 +++ 1 file changed, 3 insertions(+) diff --git a/packages/camera/camera_android_camerax/example/android/build.gradle b/packages/camera/camera_android_camerax/example/android/build.gradle index 3aa0008fd27c..6b792f1a6cf2 100644 --- a/packages/camera/camera_android_camerax/example/android/build.gradle +++ b/packages/camera/camera_android_camerax/example/android/build.gradle @@ -1,4 +1,7 @@ buildscript { + // This version should intentionally be a 1.7.* verson and lower than the + // version defined in packages/camera/camera_android_camerax/android/build.gradle. + // This tests that the kotlin version resolution continues to work. ext.kotlin_version = '1.7.10' repositories { google() From d9c2fc4fe3a9412009d00ac305cac09e1801c66e Mon Sep 17 00:00:00 2001 From: Reid Baker Date: Fri, 12 May 2023 15:48:09 -0400 Subject: [PATCH 2/2] Apply suggestions from code review --- .../camera_android_camerax/example/android/build.gradle | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/camera/camera_android_camerax/example/android/build.gradle b/packages/camera/camera_android_camerax/example/android/build.gradle index 6b792f1a6cf2..702f1d280649 100644 --- a/packages/camera/camera_android_camerax/example/android/build.gradle +++ b/packages/camera/camera_android_camerax/example/android/build.gradle @@ -1,6 +1,6 @@ buildscript { - // This version should intentionally be a 1.7.* verson and lower than the - // version defined in packages/camera/camera_android_camerax/android/build.gradle. + // This version should intentionally be a 1.7.* version and lower than the + // version of kotlin-bom defined in packages/camera/camera_android_camerax/android/build.gradle. // This tests that the kotlin version resolution continues to work. ext.kotlin_version = '1.7.10' repositories {