[ci] Update iOS simulator

[stuartmorgan]

Updates the iOS simulator used in CI from an iPhone 11 to an iPhone 13.

Part of alignment with flutter/packages in preparation for merging repositories.

Updates a Maps integration test for issues with the newer device.

[jmagman]

Hmm...

GoogleMapsUITests.m:180: error: -[GoogleMapsUITests testMapClickPage] : failed - Failed due to not able to find platform view

https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8789700651471950913/+/u/Run_plugin_tests/native_test/stdout

[jmagman]

LGTM when the tests are happy.

[stuartmorgan]

Huh. Well, that's why I wanted to pre-check!

[stuartmorgan]

@cyanglaz Are you able to reproduce this failure locally? I tried running locally with this device and it was fine.

Given the failure is around looking for that exact set of coordinates, I'm wondering if it's something like the last number being slightly different on different devices; maybe we need to be rounding somewhat in the display?

[stuartmorgan]

Oh, there are two failures. The platform view one seems very strange since the other tests look for it too, and those aren't failing.

[cyanglaz]

I haven't been able to repro mapClickPage( I will try again after figuring out mapCoodinatesPage).
For mapCoodinatesPage, the issue is the drag gesture ([platformView pressForDuration:0 thenDragToElement:titleBar];) move the map itself out of the scene. I think it could be a out of band failure. I'm going to bisect this. Could be a framework regression that we are unaware of.

Looking at the recent rollers, I don't see macOS tests ran? https://github.com/flutter/plugins/pull/7170/checks

[stuartmorgan]

Looking at the recent rollers, I don't see macOS tests ran? https://github.com/flutter/plugins/pull/7170/checks

https://github.com/flutter/plugins/pull/7170/checks?check_run_id=11304881293 is the run with these tests. If you were looking at the Cirrus section out of habit, the macOS host tests are all LUCI now :)

[stuartmorgan]

(I'm also trying flutter/packages#3199 to see if I can easily get this off the critical path of repo migration.)

[cyanglaz]

For the scrolling problem. I saw that the map doesn't have a gesture recognizer. We need to give the google map a gesture recognizer for it to take touch events from the list view. This is a bug from the example app, ill create a PR to fix it. (I'm not sure how it has been passing CI, it is concerning)

[cyanglaz]

Can you try to patch
gesture.patch
to see if mapCoodinatesPage passes.

[cyanglaz]

testMapClickPage passed (was it a flake?, we need to revisit the test to make it non-flaky.)

Actually, for testMapCoordinatesPage I read through the test more carefully, it looks like we do want to drag the map and not wanting the gesture to move the map's visible region :( sorry. @jmagman Could you please confirm since you wrote the test? :)

So we actually do not want the gesture, please revert my patch :)

[cyanglaz]

The issue with testMapCoordinatesPage is that the text region was scrolled out of the scene, it is probably hard to control for different devives.
This can be fixed by making the text stationary, one way to do it is to making the text as a stack on top of the list view. here is a patch for that:
gesture.patch

@jmagman could you please review this patch to confirm it is ok for the test?

[jmagman]

-[GoogleMapsUITests testMapClickPage] failed again: https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8789177847131715793/+/u/Run_plugin_tests/native_test/stdout
and -[VideoPlayerUITests testPlayVideo] https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8789177847131715793/+/u/Run_plugin_tests/native_test/stdout

[cyanglaz]

For [GoogleMapsUITests testMapClickPage], looks like the list button interaction failed and the map page is not showing up. It feels like the same flake we have been fixing in the framework repo last year? I remember the solution was to click again if the first time failed.

[stuartmorgan]

Changelog override: the change here is only interesting for integration tests, so is effectively dev-only.

[stuartmorgan]

I'm going to re-run tests that seem to be flake; since this is repo-merge blocking I'd like to get it landed if it fixes the non-flake issue.

[stuartmorgan]

The Android failure here is the thing that was reverted just after this PR was forked. Since this PR can't possible affect Android and the failure is already fixed on master, I'm going to just land manually instead of syncing the PR and re-running every test just for that.

[flutter-dashboard]

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.