Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keda Support #1118

Closed
willplatnick-okta opened this issue Feb 23, 2022 · 7 comments · Fixed by #1216
Closed

Keda Support #1118

willplatnick-okta opened this issue Feb 23, 2022 · 7 comments · Fixed by #1216
Assignees
Labels
kind/feature Feature request kind/upstream-blocked Depends on a missing upstream feature

Comments

@willplatnick-okta
Copy link

Keda is a useful tool for doing event-driven autoscaling in Kubernetes. To do its job, you create ScaledObject manifests, and Keda then creates and manages the HPAs itself. It would be nice if Flagger supported ScaledObject cloning and management during deploys like it does now with HPA's.

@aryan9600
Copy link
Member

Looking into this 👍

@stefanprodan stefanprodan added the kind/feature Feature request label Mar 4, 2022
@keegancwinchester
Copy link

@aryan9600 hey! any update on this?

@aryan9600
Copy link
Member

These two issues currently block KEDA support for Flagger:

@stefanprodan stefanprodan added the kind/upstream-blocked Depends on a missing upstream feature label Mar 14, 2022
@pragmaticivan
Copy link

It appears kedacore/keda#2757 is not going to fly.

What are your thoughts on allowing the triggers metadata block to be fully overwritten for canaries by using inputs from Flagger yaml instead?

@aryan9600
Copy link
Member

IMO, we'd be better off going with a find and replace approach. Having a field in the Canary spec just for this doesn't sit right with me and I can't think of which section of the spec it'd make sense to have it, semantically speaking.

@pragmaticivan
Copy link

pragmaticivan commented May 9, 2022

What are your thoughts on having Keda autoscale the Canary CRD instead? (Like it does with Argo Rollout). Ref: https://keda.sh/blog/2020-11-04-keda-2.0-release/#scaledobject-improvements

@aryan9600
Copy link
Member

aryan9600 commented May 9, 2022

That's not possible. An Argo Rollout is basically a thin wrapper around a Deployment. Thus it exposes a Scale subresource, which KEDA can use to scale the Rollout object. Canary does not have that subresource, because it uses Deployments natively. Flagger does not edit your actual/stable deployment it just makes a copy of it and then routes traffic to them according to calculated rules.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Feature request kind/upstream-blocked Depends on a missing upstream feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants