Can we make a variable for imagePullSecrets for flagger helm chart?

[cmoonExpedia]

Hi,

Can we parameterize imagePullSecrets for https://github.com/weaveworks/flagger/blob/master/charts/flagger/templates/deployment.yaml#L40 something like below so I can use your helm chart to deploy flagger from a private repository?

https://github.com/weaveworks/flagger/blob/master/charts/flagger/values.yaml

image:
  repository: weaveworks/flagger
  tag: 0.18.1
  pullPolicy: IfNotPresent
  pullSecret:

https://github.com/weaveworks/flagger/blob/master/charts/flagger/templates/deployment.yaml

...
{{- if .Values.image.pullSecret }}
imagePullSecrets:
        - name: {{ .Values.image.pullSecret }}
{{- end }}
...

Thanks.

[stefanprodan]

Sure, do you want to make a PR for this?

Thanks

[cmoonExpedia]

Sure, I think I don't have a write permission to this repo. Could you give it to me?

Thanks.

[stefanprodan]

You don't need write permission to make a PR. Fork the Flagger repo, create a branch in your clone and submit your changes as a pull request.

[stefanprodan]

@cmoonExpedia https://help.github.com/en/articles/creating-a-pull-request-from-a-fork