-
Notifications
You must be signed in to change notification settings - Fork 743
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing Kubernetes Events from Flagger #393
Comments
Kubernetes does event compaction and I'm guessing that the success rollout message (since it doesn't change) it's just omitted. If you use a new canary object is the success rollout event pushed to Slack? PS. Flagger can send events to Slack also https://docs.flagger.app/usage/alerting |
Yes, it looks like Kubernetes is compacting duplicate events. Restarting the flagger pod seems to temporarily fix it, as well as using a new Canary object. We do our own custom alerting around Canaries so I am not sure that the built-in Slack alerting will work for us. Would you accept a PR that adds an optional generic event webhook that flagger can use to send event payloads to a web server? |
There are a couple of webhook types that you could use, here are the docs https://docs.flagger.app/how-it-works#webhooks |
Please correct me if I'm wrong, but my understanding of those webhooks is that flagger uses them as part of the canary analysis to determine whether or not it should proceed to the next step of the canary rollout. What I'm looking for is a webhook that flagger can use to dump information about what it's doing (similar to how Kubernetes events are being used), so we can parse them and alert on these actions in a custom way. Is there a way that I can use the existing webhooks for this purpose? |
The pre rollout hook tells you that a canary has started and the post rollout hook tells you if it failed or not. Flagger posts a json object with the canary name, namespace and status, does this cover your use case? |
I appreciate the suggestion, but we really value the feedback about the canary analysis progress that the Kubernetes events gave us, so we're looking to something that provides us the same or similar information. |
@mrparkers we could introduce a webhook of type |
@stefanprodan opened #401 |
Expected Behavior
As the Canary Deployment rolls out, a corresponding Kubernetes Event should be created in the namespace of the application being deployed for each line in Flagger.
Current Behavior
As is shown by the logs below, and the following image, although the Canary Deployment had successfully been promoted and the logging had been reported, not all of the Kubernetes Events are being reported in the Flagger.
Context (Environment)
We are utilizing flagger by rolling out a Canary Deployment of a microservice which is part of a larger monolith. We are utilizing a Slack Operator which watches at the namespace level on the cluster for any Kubernetes Events with an
involvedObject.kind=Canary
, and reports the information of the rollout back into Slack.The text was updated successfully, but these errors were encountered: