Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No Canary is triggered on resource (cpu & memory) changes #444

Closed
simon-gloot opened this issue Feb 17, 2020 · 0 comments · Fixed by #446
Closed

No Canary is triggered on resource (cpu & memory) changes #444

simon-gloot opened this issue Feb 17, 2020 · 0 comments · Fixed by #446
Assignees
@stefanprodan
Labels
kind/bug Something isn't working

Comments

@simon-gloot
Copy link

simon-gloot commented Feb 17, 2020 •
edited
Loading

Problem:
When changing the resource requests on the deployment flagger will not trigger a canary rollout.

According to @stefanprodan:

I've found the problem, the Hash function https://github.com/weaveworks/flagger/blob/master/pkg/canary/spec.go#L15 produces the same hash for resource.Quantity pointers
@simon-gloot simon-gloot changed the title [bug] No Canary is triggered on resource (cpu & memory) changes No Canary is triggered on resource (cpu & memory) changes Feb 17, 2020
@stefanprodan stefanprodan added the kind/bug Something isn't working label Feb 18, 2020
@stefanprodan stefanprodan self-assigned this Feb 18, 2020
@stefanprodan stefanprodan mentioned this issue Feb 18, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stefanprodan stefanprodan

Labels
kind/bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix spec changes detection fluxcd/flagger
2 participants
@stefanprodan @simon-gloot