Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Prevent attack on baked-in host keys #1169

Closed
squaremo opened this issue Jun 25, 2018 · 3 comments
Closed

Prevent attack on baked-in host keys #1169

squaremo opened this issue Jun 25, 2018 · 3 comments

Comments

@squaremo
Copy link
Member

We bake a known_hosts file with entries for github.com, gitlab.com and bitbucket.com into the fluxd and helm-operator images, for convenience when using them with these services (it means you don't have to supply a known-hosts of your own).

However, an attacker with some access to the build process could substitute bogus host keys.

@stephenmoloney
Copy link
Contributor

So for reference purposes, the fingerprints (against which the ssh keys can be verified) for some of the vendors are outlined in links below:

Vendor Url
gitlab.com https://docs.gitlab.com/ee/user/gitlab_com/#ssh-host-keys-fingerprints
github.com https://help.github.com/articles/github-s-ssh-key-fingerprints/
bitbucket.com https://confluence.atlassian.com/bitbucket/ssh-keys-935365775.html?_ga=2.218915353.1800597462.1533976560-140885449.1533976560

@stephenmoloney
Copy link
Contributor

Added a script to check against pre-baked keys that came from the references above.

Ref: #1283

@stephenmoloney
Copy link
Contributor

can close now !

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants