Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Support typical chart image format in FluxHelmRelease automation #1226

Closed
oliviabarrick opened this issue Jul 12, 2018 · 0 comments
Closed

Comments

@oliviabarrick
Copy link
Contributor

The current FluxHelmRelease automation looks for image: name:tag in the values.

Most Helm charts use a different format:

image:
  repository: name
  tag: tag

It looks like it would be pretty trivial to support both formats, just have different handling for maps than strings: https://github.com/weaveworks/flux/blob/2d58c32ae195fda77450177e7d16bbc554c26975/cluster/kubernetes/resource/fluxhelmrelease.go#L63

Example:

$ helm create hello
$ cd hello
$ head values.yaml
# Default values for hello.
# This is a YAML-formatted file.
# Declare variables to be passed into your templates.

replicaCount: 1

image:
  repository: nginx
  tag: stable
  pullPolicy: IfNotPresent
$

Supporting this format would make helm-operator work with most charts out of the box.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants