Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

GitTimeout is not been used on helm-op anymore (chartsync) #1551

Closed
sfrique opened this issue Nov 23, 2018 · 2 comments · Fixed by #1565
Closed

GitTimeout is not been used on helm-op anymore (chartsync) #1551

sfrique opened this issue Nov 23, 2018 · 2 comments · Fixed by #1565
Assignees

Comments

@sfrique
Copy link
Contributor

sfrique commented Nov 23, 2018

There was some refactor on upgrading to 0.5 to use git uri per CRD and that change is not using mirrors at chartsync and not passing the timeout to git.

Here is the line:
https://github.com/weaveworks/flux/blob/master/integrations/helm/chartsync/chartsync.go#L267

@hiddeco
Copy link
Member

hiddeco commented Nov 23, 2018

@squaremo

I am wondering if this should be a per HelmRelease configuration or a global flag like it used to be, by the looks of it the --git-poll-interval flag has also stopped working (or is actually replaced by the --charts-sync-interval flag).

@sfrique
Copy link
Contributor Author

sfrique commented Nov 23, 2018

I think all git options now should be per HelmRelease each repository can have it's own key/timeout and so on.
For the charts-sync-interval I rather have it global.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants