Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Fluxd does not use configured branch for write check #1885

Closed
hiddeco opened this issue Apr 1, 2019 · 1 comment · Fixed by #1937
Closed

Fluxd does not use configured branch for write check #1885

hiddeco opened this issue Apr 1, 2019 · 1 comment · Fixed by #1937

Comments

@hiddeco
Copy link
Member

hiddeco commented Apr 1, 2019

When fluxd performs a checkout for a new repository it does a write check at a certain step. This write check creates, pushes and removes a tag pointed at the default branch and not the one configured by the user with --git-branch.

I think it would be better if we would perform the write check against the configured branch. As we now (temporary) touch something we are not explicitly told to look at and it also has a chance of (unrelated) failure, for example, when the default branch contains no commits and Flux will be unable to get a HEAD revision (caller=loop.go:90 component=sync-loop err="git repo not ready: tag for write check: fatal: Failed to resolve 'HEAD' as a valid ref.").

@squaremo
Copy link
Member

squaremo commented Apr 2, 2019

Makes sense to me.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants