Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Publication of images should happen after full build run #1997

Closed
hiddeco opened this issue Apr 30, 2019 · 1 comment
Closed

Publication of images should happen after full build run #1997

hiddeco opened this issue Apr 30, 2019 · 1 comment
Labels
build About the build or test scaffolding

Comments

@hiddeco
Copy link
Member

hiddeco commented Apr 30, 2019 •
edited
Loading

Right now our images are published before the e2e tests have run, we should change this to only publish them after all tests have run successfully to ensure it has been fully tested.

While working on this it may also be worth looking into the duplicate build that happens right now, as both the unit tests and the e2e tests build their own image.
@hiddeco hiddeco added the build About the build or test scaffolding label Apr 30, 2019
@hiddeco
Copy link
Member Author

hiddeco commented Jul 29, 2019

This got resolved in #2058.

@hiddeco hiddeco closed this as completed Jul 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
build About the build or test scaffolding
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hiddeco