Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Annotations are ignored for some kinds of resources when syncing #749

Closed
squaremo opened this issue Sep 22, 2017 · 2 comments
Closed

Annotations are ignored for some kinds of resources when syncing #749

squaremo opened this issue Sep 22, 2017 · 2 comments

Comments

@squaremo
Copy link
Member

In sync/sync.go, the manifests (files) are compared with the resources in the cluster, by cluster.Exporting and parsing the latter. But export only includes the kinds of resource we "care" about -- hitherto, namespaces, services and deployments. So an annotation on another kind of resource will not be in the results, and not be taken into account.

This is a problem when using the flux.weave.works/ignore annotation on say, a daemonset resource, because the file will be kubectl applyed regardless.

#747 will expand the set of resources we take notice of (to include daemonsets, among others), but ultimately, we want to know about anything that might appear as a manifest.

@bboreham
Copy link
Contributor

bboreham commented Oct 7, 2019

I'm puzzled about this: I have used ignore on ConfigMap in the cluster, to stop Flux re-applying the config from git, and believed it was working.

@squaremo
Copy link
Member Author

squaremo commented Oct 7, 2019

The rewrite of the syncing code in #1442 removed this limitation. Sorry for the confusing leftover issue.
(We should still bring the FAQ up to date -- thanks for filing that issue)

@squaremo squaremo closed this as completed Oct 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants