Add Insecure item for ImageRepository

[qiuming520]

Add Insecure ( +optional ) item for ImageRepository
In some cases, the secret of docker registry is kubernetes.io/dockerconfigjson, we need set insecure is true for HTTP.
I want to add feature for ImageRepository of Insecure ( +optional ) item

before

image-reflector-controller/api/v1beta1/imagerepository_types.go

Line 34 in 51caa7f

type ImageRepositorySpec struct {

image-reflector-controller/controllers/imagerepository_controller.go

Lines 216 to 232 in 51caa7f

	func parseImageReference(url string) (name.Reference, error) {
	if s := strings.Split(url, "://"); len(s) > 1 {
	return nil, fmt.Errorf(".spec.image value should not start with URL scheme; remove '%s://'", s[0])
	}
	ref, err := name.ParseReference(url)
	if err != nil {
	return nil, err
	}
	imageName := strings.TrimPrefix(url, ref.Context().RegistryStr())
	if s := strings.Split(imageName, ":"); len(s) > 1 {
	return nil, fmt.Errorf(".spec.image value should not contain a tag; remove ':%s'", s[1])
	}
	return ref, nil
	}

after

type ImageRepositorySpec struct {
	// +optional
	Insecure bool `json:"insecure,omitempty"`
       
        ...
}

func parseImageReference(url string, insecure bool) (name.Reference, error) {
	if s := strings.Split(url, "://"); len(s) > 1 {
		return nil, fmt.Errorf(".spec.image value should not start with URL scheme; remove '%s://'", s[0])
	}

	var ref name.Reference
	var err error
	if insecure {
		ref, err = name.ParseReference(url, name.Insecure)
	} else {
		ref, err = name.ParseReference(url)
	}
	
	if err != nil {
		return nil, err
	}

	imageName := strings.TrimPrefix(url, ref.Context().RegistryStr())
	if s := strings.Split(imageName, ":"); len(s) > 1 {
		return nil, fmt.Errorf(".spec.image value should not contain a tag; remove ':%s'", s[1])
	}

	return ref, nil
}

[aryan9600]

hi @qiuming520, thanks for opening this. this is planned and right now blocked behind a RFC: fluxcd/flux2#3081. once the RFC gets merged, we can start work on this.

[qiuming520]

Get ！Hope to have a conclusion soon