Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding object kind to notifications #120

Closed
Kube-ASY opened this issue Jan 18, 2021 · 1 comment · Fixed by #124
Closed

Adding object kind to notifications #120

Kube-ASY opened this issue Jan 18, 2021 · 1 comment · Fixed by #124
Labels
area/alerting Alerting related issues and PRs enhancement New feature or request

Comments

@Kube-ASY
Copy link

In some notification providers like Teams it is not always clear from which object type the notifications origin.

In Slack the originating controller is used as a username of the message, but in Teams the username is set by the webhook configuration.

Would it be possible to add the Kind of the causing object to the objName that is part of the message.
E.g. as pre-/ or postfix like
<Kind>/<name>.<namespace>
or
<name>.<namespace>.<kind> (to stay in hostname notation)

(from fluxcd/flux2#710 )

@stefanprodan
Copy link
Member

@somtochiama please implement <Kind>/<name>.<namespace>.

@stefanprodan stefanprodan added area/alerting Alerting related issues and PRs enhancement New feature or request labels Jan 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/alerting Alerting related issues and PRs enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants