Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Token leaked in logs #270

Closed
swapnild2111 opened this issue Oct 20, 2021 · 0 comments · Fixed by #271
Closed

Token leaked in logs #270

swapnild2111 opened this issue Oct 20, 2021 · 0 comments · Fixed by #271
Labels
area/alerting Alerting related issues and PRs bug Something isn't working

Comments

@swapnild2111
Copy link

Generate token with echo 'token' | base64 and then use that in github provider - makes notification-controller push commit status request fail and prints the token in logs.

Detailed discussion:
https://cloud-native.slack.com/archives/CLAJ40HV3/p1634762065311300
@stefanprodan stefanprodan added area/alerting Alerting related issues and PRs bug Something isn't working labels Oct 21, 2021
@somtochiama somtochiama mentioned this issue Oct 21, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/alerting Alerting related issues and PRs bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use regex to find and replace token somtochiama/notification-controller
2 participants
@stefanprodan @swapnild2111