Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to HTTP(s) endpoint as Bucket source #808

Open
laozc opened this issue Jul 1, 2022 · 4 comments
Open

Add support to HTTP(s) endpoint as Bucket source #808

laozc opened this issue Jul 1, 2022 · 4 comments

Comments

@laozc
Copy link
Contributor

laozc commented Jul 1, 2022

The idea is to provide the ability to create a Bucket with a generic HTTP(s) endpoint for downstream consumption,
such as Kustomization controller which requires either Git/Bucket sources.

This could allow flux components to integrate with other in-cluster services providing HTTP access to resource manifest.

@hiddeco
Copy link
Member

hiddeco commented Jul 1, 2022

I am not sure I agree on expanding the Bucket source to allow this, as the proposed is a simple file downloader and not something which iterates over an HTTP endpoint.

Given this, I think people quickly would want to be able to compose a list of URLs to download and create an artifact out of, which isn't something the Bucket kind could be expanded to, as it would not fit with actual Bucket implementations.

@stefanprodan
Copy link
Member

@laozc what you are proposing here is a major change to Flux that needs go over an RFC process. IMO fetching files from random HTTP/S servers is not in scope for the Bucket kind.

@laozc
Copy link
Contributor Author

laozc commented Jul 1, 2022

@stefanprodan Sure. Let me work on a RFC to discuss this further.

@stefanprodan
Copy link
Member

@laozc I would close the PR opened for this, as we can't get that in, not in the current shape anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants