Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate checksum before consuming golang-with-libgit2 artefacts #820

Closed
pjbgf opened this issue Jul 7, 2022 · 2 comments · Fixed by #823
Closed

Validate checksum before consuming golang-with-libgit2 artefacts #820

pjbgf opened this issue Jul 7, 2022 · 2 comments · Fixed by #823
Assignees
Labels
area/ci CI related issues and pull requests area/security Security related issues and pull requests good first issue Good for newcomers
Milestone

Comments

@pjbgf
Copy link
Member

pjbgf commented Jul 7, 2022

The golang-with-libgit2 project has recently started providing signed releases for its artefacts.

The current logic needs to be updated to add said validation:

curl -o output.tar.gz -LO "https://github.com/fluxcd/golang-with-libgit2/releases/download/${TAG}/darwin-libs.tar.gz"

@pjbgf pjbgf added good first issue Good for newcomers area/ci CI related issues and pull requests area/security Security related issues and pull requests labels Jul 7, 2022
@pjbgf pjbgf added this to the GA milestone Jul 7, 2022
@stefanprodan
Copy link
Member

@pjbgf I see no signed release in here https://github.com/fluxcd/golang-with-libgit2/releases last one was in May.

@pjbgf
Copy link
Member Author

pjbgf commented Jul 7, 2022

@stefanprodan yep, there was an issue with the tag which I am working on atm. We should have a new release out at some point Today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ci CI related issues and pull requests area/security Security related issues and pull requests good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants