Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(a380x/pfd): Inverted meter altitude indicator color below and above the MDA #9713

Conversation

ItzARz
Copy link
Contributor

@ItzARz ItzARz commented Jan 4, 2025

Fixes #9712

Summary of Changes

Updated the comparison logic to ensure AMBER color is shown when the altitude is below MDA, and green when above it.

Screenshots (if necessary)

Above
FlightSimulator 2025-01-04 15-43-13

Below
FlightSimulator 2025-01-04 15-43-30

References

Additional context

Discord username: itzarz

Testing instructions

  1. Push 'meter' button in the AFS Panel.
  2. Check the PFD, the meter altitude indicator should be in GREEN color above the MDA and AMBER below.

How to download the PR for QA

Every new commit to this PR will cause new A32NX and A380X artifacts to be created, built, and uploaded.

  1. Make sure you are signed in to GitHub
  2. Click on the Checks tab on the PR
  3. On the left side, find and click on the PR Build tab
  4. Click on either flybywire-aircraft-a320-neo, flybywire-aircraft-a380-842 (4K) or flybywire-aircraft-a380-842 (8K) download link at the bottom of the page

@ItzARz ItzARz changed the title fix(a380x/pfd): Inverted meter altitude indicator color fix(a380x/pfd): Inverted meter altitude indicator color below and above the MDA Jan 4, 2025
Copy link
Member

@lukecologne lukecologne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

@ItzARz
Copy link
Contributor Author

ItzARz commented Jan 26, 2025

Thanks for the contribution!

Happy to help

@BravoMike99 BravoMike99 added QA Tier 1 QA Ready to Test A380X Related to the A380X aircraft labels Jan 26, 2025
@utkrishtm
Copy link

Quality Assurance Trainee Report

Discord Username : utkrishtm
Object of testing : #9713
Aircraft : A380X
Tier of Testing : 1
Date : 09/02/2025

Testing Process:

  • Loaded the MDA from the charts into the FMS
  • Climbed above the MDA and descended below the MDA multiple times.

Testing Results:
Passed

@flogross89 flogross89 enabled auto-merge (squash) February 9, 2025 16:38
@flogross89
Copy link
Contributor

@ItzARz Could you de-conflict the changelog? It will auto-merge after that

auto-merge was automatically disabled February 9, 2025 17:26

Head branch was pushed to by a user without write access

@flogross89 flogross89 enabled auto-merge (squash) February 9, 2025 19:21
@flogross89 flogross89 merged commit d993d04 into flybywiresim:master Feb 9, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: ✔️ Done
Development

Successfully merging this pull request may close these issues.

PFD: Meter altitude indicator amber when above minimum and green once below
5 participants