-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(a380/nd): Fixed TCAS message position and add TCAS STBY #9789
base: master
Are you sure you want to change the base?
fix(a380/nd): Fixed TCAS message position and add TCAS STBY #9789
Conversation
We should think about whether it makes sense for these messages to actually just be part of the aircraft rather than the fbw-common part of the ND, as they differ in many ways (more than now when fully realised), and having them in fbw-common makes it harder to fix them up to use the proper ARINC429 words in the A32NX and AFDX in the A380X for example. I think those things outweigh duplication of some trivial code, and it ends up tidier than these CSS classes. |
Made requested changes |
Is this for A32NX as well or just A380X now? Please update the testing instructions as needed. |
testing instructions step 6 already references that there should be no changes seen in the A32NX. The code changes do affect both. |
The reason why I asked was the A32NX label was removed so just making sure. |
Quality Assurance Trainee Report Discord Username : utkrishtm Testing Process:
Testing Results: |
Fixes #9054
Summary of Changes
Updated logic on dynamic class for TCAS messages
Added class to adjust text position for A380 TCAS Messages
Added TCAS STBY display
Added class to hide in A32NX
Screenshots (if necessary)
References
Other video references on issue #9054
Additional context
I've added the TCAS STBY in using CSS classes but if the preference would be to do it via a prop I can change it
Discord username (if different from GitHub):MrJigs.
Testing instructions
How to download the PR for QA
Every new commit to this PR will cause new A32NX and A380X artifacts to be created, built, and uploaded.