Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(a380x/fctl): Automatic THS trim after engine start or touch and go #9843

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

flogross89
Copy link
Contributor

@flogross89 flogross89 commented Feb 8, 2025

Summary of Changes

Adds auto THS trim after engine start or when performing touch and go.
Also, cleans up some XML for the pedestal and the visibility conditions for the magenta GW CG box in the PFD's pitch trim indicator.

Conditions for engine start:

  • First engine is started and a hydraulic system (G or Y) is pressurized OR
  • Ground spoilers become armed

Conditions for touch and go:

  • On ground for at least one second
  • Airspeed greater than 80kts
  • One of the following actions performed: Flaps lever moved, ground spoilers disarmed or at least one thrust levers moved out of IDLE

Screenshots (if necessary)

References

Additional context

Discord username (if different from GitHub):

Testing instructions

  1. Start cold&dark at gate
  2. Perform engine start per SOP, THS trim should move automatically
  3. Perform take-off, traffic pattern and touch and go. THS trim should move automatically during touch and go
    Verify, that magenta PFD pitch trim indicator is only visible after first engine started and HYD is pressurized, and disappears after takeoff (not visible for landing)

How to download the PR for QA

Every new commit to this PR will cause new A32NX and A380X artifacts to be created, built, and uploaded.

  1. Make sure you are signed in to GitHub
  2. Click on the Checks tab on the PR
  3. On the left side, find and click on the PR Build tab
  4. Click on either flybywire-aircraft-a320-neo, flybywire-aircraft-a380-842 (4K) or flybywire-aircraft-a380-842 (8K) download link at the bottom of the page

@flogross89 flogross89 added QA A380 Only QA only for A380 required A380X Related to the A380X aircraft labels Feb 8, 2025
@flogross89 flogross89 added this to the v0.13.0 milestone Feb 8, 2025
@aadee9940
Copy link

aadee9940 commented Feb 8, 2025

I know the code is still ready for review, but i had a bit of time so just wanted to try it out.

Engine start automatic THS:
https://github.com/user-attachments/assets/240ac7c7-6321-4efe-bfe5-1ff833cdf886

Touch and go:
This one I am not sure about, after doing the traffic pattern, on the approach, shouldn't LAND and FLARE be on the FMA? As well as ROLLOUT. Anyways, during touch and go, set flaps to FULL->3 and TOGA. The THS value on the SD was changing.

2025-02-08.22-26-47.mp4

@Ueeew
Copy link

Ueeew commented Feb 9, 2025

@flogross89 I just wanted to give a few tips or improvements. The first thing I noticed is that process of setting the trim automatically takes way to long. In the real aircraft the process of setting the THS takes only about 2-3 seconds(Real video for reference). In the FBW it takes about 5 or even longer.
The second thing is that the purple box, indicating the optimal THS setting ,is IR only shown a few seconds prior to auto THS setting process (shown in video). In FBW the box is shown the whole time as long as THS setting is visible on PFD.
https://m.youtube.com/watch?v=uEgw2p8J0ZA&t=775s&pp=2AGHBpACAcoFDUEzODAgdGhzIHRyaW0%3D
The engine stat sequence is at minute 2:45. Unfortunately you may have to zoom a bit in to see the process.
hopefully this helps

@flogross89
Copy link
Contributor Author

@aadee9940 Thanks a lot! Have you considered joining our QA team?
It seems you didn’t arm any approach mode for your landing, but instead followed the flight plan guidance down to the runway. Did you tune an ILS, and press APP to intercept LOC and G/S?
The FMA modes are untouched by this PR, so that also wouldn’t be related.

@flogross89
Copy link
Contributor Author

@Ueeew Very helpful, thanks! Indeed, the speed is far too slow, might need to check my triggering mechanism again, I believe I have to use another method.
about the magenta box: Also well spotted, I suppose the GW CG comes from the FQMS, which only sends these values after engine start or some other condition. I‘ll investigate in my references.

@aadee9940
Copy link

@flogross89 unfortunately I don't have access to the FBW server as before, but if the mods want to have a look at my appeal LMK 😊

Yeah it completely left my mind I have to program my automatics to get proper FMA modes on landing, my fault 😂.
It was a fully visual circuit so yeah, but I hope my test shows what you are looking for? (The THS trim moving on the SD)
Wasn't really sure if this was EXACTLY what you were looking for..

@flogross89
Copy link
Contributor Author

@aadee9940 Ah, didn't know that. I'm not a mod so I don't know any details, but I trust their process. Yep, that's what I wanted to see,

@Ueeew I changed the trim triggering mechanism, it should now use the full available speed (which is limited by the PRIMs, so that should be accurate).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A380X Related to the A380X aircraft QA A380 Only QA only for A380 required
Projects
Status: 🟡 Code Review: Ready for Review
Development

Successfully merging this pull request may close these issues.

3 participants