-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do you have a plane to Change the name of API ? #7
Comments
This lib is looking awesome and it's performance is very good. 👍 I would also like to see the naming conventions more along the lines of ECMAScript standards. |
Why? On my side, I'm in favor of using Box2D standards. To improve code portability. |
I also don't like the Box2D API naming BUT to benefit Box2D manual and tuts on internet, changing API may not be a good idea. Instead I have some wrapper classes on my project to use Box2D easily. |
Yeah, I think I'm going to leave it as close to the original API as possible. Perhaps a wrapper that added some of these JS features would be nice, especially if the underlying physics engine could be swapped out. |
@flyover , Hi ,
Do you have a plane to Change the name of API , then provide a JavaScript-friendly API ?
example:
box2d.b2BodyDef --> Box2d.bodyDef
world.CreateBody --> world.createBody
b2BodyType.b2_dynamicBody --> bodyType.dynamicBody
...
the things https://github.com/shakiba/planck.js do :
b2
prefix is dropped from class names, for exampleb2World
is now available asplanck.World
.{}
).World#on(eventName, listenerFn)
andWorld#off(eventName, listenerFn)
are added to add and remove event listeners. Currently supported events are:'begin-contact'
'end-contact'
'pre-solve'
'post-solve'
'joint-removed'
'fixture-removed'
The text was updated successfully, but these errors were encountered: