diff --git a/docs/rules.md b/docs/rules.md index b60093e..ace13fb 100755 --- a/docs/rules.md +++ b/docs/rules.md @@ -65,7 +65,7 @@ cc_library( ## java_library_with_native
-java_library_with_native(name, visibility, native_libs, tags, java_library_args) +java_library_with_native(name, native_libs, tags, visibility, java_library_args)@@ -76,9 +76,9 @@ java_library_with_native(name, name |
-
| none | -| visibility |-
|None
|
| native_libs | -
|None
|
| tags | -
|None
|
+| visibility | -
|None
|
| java_library_args | -
| none | diff --git a/jni/internal/java_library_with_native.bzl b/jni/internal/java_library_with_native.bzl index e2208e9..58e2e6f 100644 --- a/jni/internal/java_library_with_native.bzl +++ b/jni/internal/java_library_with_native.bzl @@ -16,9 +16,9 @@ load(":common.bzl", "merge_java_infos", "original_java_library_name") def java_library_with_native( name, - visibility = None, native_libs = None, tags = None, + visibility = None, **java_library_args): original_name = original_java_library_name(name) @@ -26,13 +26,9 @@ def java_library_with_native( java_library_args.setdefault("deps", []) java_library_args["deps"] += ["@fmeum_rules_jni//jni/tools/native_loader"] - java_library_args.setdefault("tags", []) - if tags: - java_library_args["tags"] += tags - if "manual" not in java_library_args["tags"]: - java_library_args["tags"].append("manual") native.java_library( name = original_name, + tags = ["manual"], visibility = visibility, **java_library_args ) diff --git a/jni/internal/java_native_library.bzl b/jni/internal/java_native_library.bzl index 9ff1549..e3a35b3 100644 --- a/jni/internal/java_native_library.bzl +++ b/jni/internal/java_native_library.bzl @@ -226,13 +226,6 @@ def java_native_library( unix_library_name = "lib%s.so" % name windows_library_name = "%s.dll" % name - # Label cc_binary targets as manual as they should not be built - # unnecessarily in the untransitioned configuration. - cc_binary_args.setdefault("tags", []) - if tags: - cc_binary_args["tags"] += tags - if "manual" not in cc_binary_args["tags"]: - cc_binary_args["tags"].append("manual") cc_binary_args.setdefault("deps", []) # Simple concatenation is compatible with select, append is not. @@ -245,6 +238,7 @@ def java_native_library( name = macos_library_name, linkshared = True, linkstatic = True, + tags = ["manual"], visibility = ["//visibility:private"], **cc_binary_args ) @@ -252,6 +246,7 @@ def java_native_library( name = unix_library_name, linkshared = True, linkstatic = True, + tags = ["manual"], visibility = ["//visibility:private"], **cc_binary_args ) @@ -259,6 +254,7 @@ def java_native_library( name = windows_library_name, linkshared = True, linkstatic = True, + tags = ["manual"], visibility = ["//visibility:private"], **cc_binary_args )