-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow non-iostream builds? #205
Comments
Hi, |
Just a personal hatred for the entire stream system and API, both from a performance, and a readability perspective. Your library seems quite nice, since I'm not a fan of the printf system either. It would be a shame for it to be saddled by the streams ogre :-) |
Not a big fan of IOStreams myself, but I'd rather not clutter the code with more |
No problem. If #ifdefs are too bothersome, then just put the stream functions into seperate files and make using streams (or disabling them) optional in the cmake file then. |
Whoops, just realised you're aiming for a 2 file library, so splitting the functions into their own files wouldn't work. Which makes me ask why you are bothered by another #if*? considering you have 38 in the header file and 15 in the cc. Noting importance, I'm also concerned with compile time. Include a stream header in a project DOES impacts compile time (although I admit only on mechanical HDDs, I compile on an SSD and it only increases build time by 2.5%) |
Anyway, I can do a pull request if you want. |
I wish I could kill them =). Anyway, if you feel strongly about not using iostreams, please do submit a PR. |
If I'm allowed to ask, I'd like to know why the IOStreams are such a thing to worry about here, it seems close to little point in providing a removal of the streams, even if they are rather...well, eh, but is there really a benefit to doing this? (seeing as they most only provide functionality, and aren't actually used) |
@Spartan322 I'm somewhat skeptical myself as to practical benefit of this. 2.5% reduction in compile time doesn't sound like a big gain. |
Pull request as Issue #208. |
Hello,
would it be possible to make it so that I can use the format.cc/h library without it referencing any of the
*stream
headers/libraries?I quickly hacked the files removing any reference to istream/ostream/sstream and it seemed to build fine (g++ 5.2.0). So it seems like an easy do.
The text was updated successfully, but these errors were encountered: