From 70711a024d947cc1393cce53d76410e2abee0204 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Martin=20W=C3=BChrer?= Date: Thu, 13 Aug 2020 21:43:44 +0200 Subject: [PATCH 1/3] CMakeLists.txt: Clang-warnings: removed -Wno-sign-conversion --- CMakeLists.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index c13a0610b46b..0112368fba83 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -130,7 +130,7 @@ endif () if (CMAKE_CXX_COMPILER_ID MATCHES "Clang") set(PEDANTIC_COMPILE_FLAGS -Wall -Wextra -pedantic -Wconversion - -Wno-sign-conversion -Wdeprecated -Wweak-vtables) + -Wdeprecated -Wweak-vtables) check_cxx_compiler_flag(-Wzero-as-null-pointer-constant HAS_NULLPTR_WARNING) if (HAS_NULLPTR_WARNING) set(PEDANTIC_COMPILE_FLAGS ${PEDANTIC_COMPILE_FLAGS} From 6a54d5c15a9d1e44450db38075c809d1f5564f5c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Martin=20W=C3=BChrer?= Date: Fri, 14 Aug 2020 07:51:19 +0200 Subject: [PATCH 2/3] test/ranges-test.cc: changed type of integer literals to unsigned --- test/ranges-test.cc | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/test/ranges-test.cc b/test/ranges-test.cc index 518e7ba26f95..19122047efcf 100644 --- a/test/ranges-test.cc +++ b/test/ranges-test.cc @@ -175,15 +175,17 @@ template class non_const_only_range { }; TEST(RangesTest, JoinRange) { - non_const_only_range x(3, 0); + non_const_only_range x(3u, 0); EXPECT_EQ("0,0,0", fmt::format("{}", fmt::join(x, ","))); - EXPECT_EQ("0,0,0", - fmt::format("{}", fmt::join(non_const_only_range(3, 0), ","))); + EXPECT_EQ( + "0,0,0", + fmt::format("{}", fmt::join(non_const_only_range(3u, 0), ","))); - std::vector y(3, 0); + std::vector y(3u, 0); EXPECT_EQ("0,0,0", fmt::format("{}", fmt::join(y, ","))); - EXPECT_EQ("0,0,0", fmt::format("{}", fmt::join(std::vector(3, 0), ","))); + EXPECT_EQ("0,0,0", + fmt::format("{}", fmt::join(std::vector(3u, 0), ","))); - const std::vector z(3, 0); + const std::vector z(3u, 0); EXPECT_EQ("0,0,0", fmt::format("{}", fmt::join(z, ","))); } From 246c2eab0d1126fe83d0888f2b1ffce13f8a40d9 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Martin=20W=C3=BChrer?= Date: Fri, 14 Aug 2020 08:18:13 +0200 Subject: [PATCH 3/3] test/format-test.cc: fixed implicit conversion changes signedness warning in clang --- test/format-test.cc | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/test/format-test.cc b/test/format-test.cc index d0a38f258975..33e620f70d74 100644 --- a/test/format-test.cc +++ b/test/format-test.cc @@ -1828,14 +1828,18 @@ class mock_arg_formatter } template - typename std::enable_if::value, iterator>::type + typename std::enable_if::value && + fmt::detail::is_signed::value, + iterator>::type operator()(T value) { call(value); return base::operator()(value); } template - typename std::enable_if::value, iterator>::type + typename std::enable_if::value && + fmt::detail::is_signed::value), + iterator>::type operator()(T value) { return base::operator()(value); }