Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for note renaming #809

Closed
AndreiD049 opened this issue Nov 1, 2021 · 4 comments
Closed

Add support for note renaming #809

AndreiD049 opened this issue Nov 1, 2021 · 4 comments
Labels
foam-core Related to API, core model or feature
Milestone

Comments

@AndreiD049
Copy link
Contributor

AndreiD049 commented Nov 1, 2021

  • Foam version: v0.15.2
  • Platform: Windows
  • Issue occur on the foam template repo: Yes

Summary

My file structure has some folders in it, just to avoid having big amount of files in the root folder. When i create a new note, i would just type it's name [[example-new-note]] and Ctrl+click it to be created. This creates the note in the root folder, then i move the file in the folder i want it to be. When i do this, i can still click the [[example-new-note]] and it will get me to the correct file. But i cannot see the backlinks, and on the graph, there are duplicated nodes, one linked, and another one orphan. See print screens in repro steps:

Steps to reproduce

  1. I create the [[items]] note, and ctrl+click it to be created
    image
  2. Then i move this file to another folder, for example to /docs:
    image
  3. I can navigate to [[items]] by clicking on the link from Inbox, but when i get there, there are no backlinks:
    image

What i see on the graph (duplicated nodes, 1 linked with the graph, other one orphan):
image

Additional information
I reproduced this on a clean copy of foam template
In case additional info needed, please let me know

@AndreiD049 AndreiD049 added the bug Something isn't working label Nov 1, 2021
@dmurph
Copy link
Contributor

dmurph commented Nov 1, 2021

I also have this issue. A restart usually solves it. There are also issues in the "orphans" section. It seems like the foam graph doesn't get updated on file moves, and I'm not sure if there is a command or something we can execute to do a rescan?

@riccardoferretti
Copy link
Collaborator

yes, this is the same as #810 - we need to add support for note moving/renaming

@riccardoferretti riccardoferretti added foam-core Related to API, core model or feature and removed bug Something isn't working labels Nov 3, 2021
@riccardoferretti riccardoferretti changed the title Issue when moving files Add support for note renaming Nov 3, 2021
@riccardoferretti riccardoferretti added this to the 1.0.0 milestone Dec 2, 2021
@riccardoferretti
Copy link
Collaborator

related #305

@riccardoferretti
Copy link
Collaborator

Note renaming supported in 0.18.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
foam-core Related to API, core model or feature
Projects
None yet
Development

No branches or pull requests

3 participants