fix(config): select fg by maximizing contrast rather than check if a color is dark
#316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
mehalter
changed the title
fg by maximizing contrast rather than check if a color is darkfg by maximizing contrast rather than check if a color is dark
mehalter
force-pushed
the
fg_fix
branch
2 times, most recently
from
e217aa3 to
85a751c
Compare
|
Awesome, ty! |
folke
pushed a commit
that referenced
this pull request
Sep 16, 2024
🤖 I have created a release *beep* *boop* --- ## [1.4.0](v1.3.0...v1.4.0) (2024-09-16) ### Features * **fzf:** add fzf-lua support in Readme & add TodoFzfLua command ([#312](#312)) ([6d6cf47](6d6cf47)) ### Bug Fixes * **config:** select `fg` by maximizing contrast rather than check if a color is dark ([#316](#316)) ([76990a9](76990a9)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR changes a bit of of the internal logic used for calculating the foreground for a given background color. Currently it uses an algorithm to guess if the dark or light color is better. This rather uses the contrast ratio metric as described by the WCAG to maximize visual difference between the foreground and background.
Let me know what you think of this solution! Thanks so much for a great plugin!
EDIT: moved from Euclidian distance in the RGB space to the official contrast definition by the WCAG for identifying the contrast between foreground and background colors which accounts for difference in color perception to the human eye. (https://www.w3.org/WAI/WCAG21/Understanding/contrast-minimum.html)
Related Issue(s)
Fixes #315
Screenshots
Here is a color that resolves incorrectly without this PR:
Here is the same color with this PR: