Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Build] Not LESS 4 compatible #1818

Closed
arichiardi opened this issue Dec 26, 2020 · 2 comments
Closed

[Build] Not LESS 4 compatible #1818

arichiardi opened this issue Dec 26, 2020 · 2 comments
Assignees
Labels
type/bug Any issue which is a bug or PR which fixes a bug type/build Anything related to the build process
Milestone

Comments

@arichiardi
Copy link

Bug Report

This is a problem I detected when upgrading Less to version 4 and therefor this belongs to https://github.com/fomantic/Fomantic-UI-LESS

I have discovered that Less 4 adds new math-related options (less/less.js#3274) and enforces parenthesis for division (less/less.js@58c89ee).

This breaks compilation, see below.

Steps to reproduce

  1. Bump Less to version 4
  2. Compile Fomantic-UI-LESS

Expected result

Successful compilation.

Actual result

The output is:

[lessc] - ArgumentError: Error evaluating function `unit`: the first argument to unit must be a number. Have you forgotten parenthesis? in /home/kapitan/.boot/cache/tmp/home/kapitan/git/ar-website/8lt/cz07er/css/themes/default/globals/site.variables on line 653, column 20:
652 @largeRaw        : unit( round(@largeSize * @emSize) / @emSize );
653 @bigRaw          : unit( round(@bigSize * @emSize) / @emSize );
654 @hugeRaw         : unit( round(@hugeSize * @emSize) / @emSize );

Version

2.8.7

@arichiardi arichiardi added state/awaiting-investigation Anything which needs more investigation state/awaiting-triage Any issues or pull requests which haven't yet been triaged type/bug Any issue which is a bug or PR which fixes a bug labels Dec 26, 2020
@lubber-de lubber-de changed the title [lees] summary of your bug [Build] Not LESS 4 compatible Dec 26, 2020
@lubber-de lubber-de self-assigned this Dec 26, 2020
@lubber-de lubber-de added type/build Anything related to the build process and removed state/awaiting-investigation Anything which needs more investigation state/awaiting-triage Any issues or pull requests which haven't yet been triaged labels Dec 26, 2020
@lubber-de lubber-de added this to the 2.8.8 milestone Dec 26, 2020
@lubber-de
Copy link
Member

Thanks for the bug report. It's fixed by #1819.

@lubber-de lubber-de added the state/has-pr An issue which has a related PR open label Dec 26, 2020
@arichiardi
Copy link
Author

Well thank you for the patch!

@lubber-de lubber-de added tag/next-release/nightly Any issue which has a corresponding PR which has been merged and is available in the nightly build and removed state/has-pr An issue which has a related PR open labels Dec 27, 2020
@lubber-de lubber-de removed the tag/next-release/nightly Any issue which has a corresponding PR which has been merged and is available in the nightly build label Jun 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/bug Any issue which is a bug or PR which fixes a bug type/build Anything related to the build process
Projects
None yet
Development

No branches or pull requests

2 participants