Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Buttons do not maintain top margin when stacking #2016

Closed
otavioserra opened this issue Jul 13, 2021 · 3 comments
Closed

Buttons do not maintain top margin when stacking #2016

otavioserra opened this issue Jul 13, 2021 · 3 comments
Labels
type/usage Any support issues asking for help

Comments

@otavioserra
Copy link

Bug Report

Buttons don't maintain margin top when stacking against each other in responsive layouts.

Steps to reproduce

  1. Create a set of at least 6 buttons with the default "ui button" classes.
  2. Make the published HTML page window small so that the buttons stack
  3. With the buttons stacked, they do not maintain a margin between the elements of a line with the line below.

Expected result

Buttons when stacked on a responsive page are expected to maintain a margin between them as per the https://fomantic-ui.com/elements/button.html#social manual

Actual result

The buttons are not keeping a margin between them and are glued together as if there is no margin between them.

Testcase

https://jsfiddle.net/1bw9mgnL/

Screenshot (if possible)

https://beta.entrey.com.br/files/2021/07/captura-de-tela-2021-07-13-145711.jpg

Version

2.8.8

@otavioserra otavioserra added state/awaiting-investigation Anything which needs more investigation state/awaiting-triage Any issues or pull requests which haven't yet been triaged type/bug Any issue which is a bug or PR which fixes a bug labels Jul 13, 2021
@lubber-de
Copy link
Member

lubber-de commented Jul 13, 2021

On the docs page this is a custom CSS Setting. You can easily adopt this in your jsfiddle by adding

.segment > .button {
  margin-bottom: 0.75em;
}

See https://jsfiddle.net/lubber/w214at8g/2/

But we cannot add a bottom margin to each button as a default (this would break lots of existing layouts and also some other modules which make use of buttons would break.)
As FUI cannot know how each custom layout looks like, I don't think we can easily fix this without breaking a ton of existing projects.
Thus, this is more of a usage question instead of a bug. Workaround given above 🙂

If your layout has more buttons than a mobile view allows, there is also stackable buttons variation. Looks of course different
https://jsfiddle.net/lubber/w214at8g/4/
https://fomantic-ui.com/elements/button.html#stackable-buttons

@lubber-de lubber-de added type/usage Any support issues asking for help and removed state/awaiting-investigation Anything which needs more investigation state/awaiting-triage Any issues or pull requests which haven't yet been triaged type/bug Any issue which is a bug or PR which fixes a bug labels Jul 13, 2021
@otavioserra
Copy link
Author

@lubber-de thank you for your help and thank you for your really nice work with Fomantic-UI. If it helps: I think is better show this type/user on main documantation because I lost a lot of time try to find this option. And only after you showed me this option that I undestand.

OFF-TOPIC: In a short time when I'll finish my platform, I'll present you our platform to sell services using Fomantic-UI as a primary system UI. How can I contact you when it occurs?

@lubber-de
Copy link
Member

lubber-de commented Jul 16, 2021

In a short time when I'll finish my platform, I'll present you our platform to sell services using Fomantic-UI as a primary system UI. How can I contact you when it occurs?

You may post it in the showroom https://github.com/fomantic/Fomantic-UI/discussions/categories/showroom and/or on our Discord Server https://discord.gg/YChxjJ3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/usage Any support issues asking for help
Projects
None yet
Development

No branches or pull requests

2 participants