Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Version value in HEAD should be in sync with version string #112

Open
puzrin opened this issue Jun 18, 2021 · 0 comments
Open

Version value in HEAD should be in sync with version string #112

puzrin opened this issue Jun 18, 2021 · 0 comments

Comments

@puzrin
Copy link
Member

puzrin commented Jun 18, 2021 •
edited
Loading

Problem

  1. --version adds string to name table, but does nothing with version field in head table.
  2. There are no guarantee to generate proper value from arbitrary input

Proposal

  • Add --version-num option.
  • Try to extract version value when possible, and advise use --version-num on fail.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@puzrin