fix active storage links for attachments #1045
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mortbauer
force-pushed
the
fix/active-storage-attachment-links
branch
2 times, most recently
from
efb27f2 to
6c0baf8
Compare
|
Ok, this one took a long time to find, I think it might really work now! |
mortbauer
force-pushed
the
fix/active-storage-attachment-links
branch
from
6c0baf8 to
67c8237
Compare
|
Ok, rubocop is still failing but this is more or less code from rails activestorage itself. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we had strange issues with the current implementation, best described here:
with this fix the issues are gone.