Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

M20 is triggered twice after streaming to SD #1274

Closed
foosel opened this issue Mar 11, 2016 · 1 comment
Closed

M20 is triggered twice after streaming to SD #1274

foosel opened this issue Mar 11, 2016 · 1 comment
Assignees
@foosel
Labels
bug Issue describes a bug done Done but not yet released
Milestone
1.2.10

Comments

@foosel
Copy link
Member

foosel commented Mar 11, 2016

Problem

After finishing streaming a file to SD, M20 to refresh the SD file list is triggered twice. Once after sending the M29, once after receiving the Done saving file response from the firmware.

That produces unnecessary overhead in the printer communication.

Solution

Remove M20 request from Done saving file handler.
@foosel foosel added the bug Issue describes a bug label Mar 11, 2016
@foosel foosel self-assigned this Mar 11, 2016
@foosel foosel added this to the 1.2.10 milestone Mar 11, 2016
@foosel
Copy link
Member Author

foosel commented Mar 11, 2016

See also #450 (comment)

@foosel foosel mentioned this issue Mar 11, 2016
Open
@foosel foosel added the done Done but not yet released label Mar 11, 2016
@foosel foosel closed this as completed in 29aefde Mar 16, 2016
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@foosel foosel

Labels
bug Issue describes a bug done Done but not yet released
Projects
None yet
Milestone
1.2.10
Development

No branches or pull requests
1 participant
@foosel