Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): bump forbole/juno to v3.0.0 #356

Merged
merged 64 commits into from
Apr 1, 2022

Conversation

MonikaCat
Copy link
Contributor

@MonikaCat MonikaCat commented Mar 10, 2022

Description

This PR updated Juno to v3.0.0.

Closes: #282
Closes: #346
Closes: #306


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch
  • provided a link to the relevant issue or specification
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@MonikaCat MonikaCat marked this pull request as ready for review March 16, 2022 15:37
@MonikaCat MonikaCat requested a review from huichiaotsou March 16, 2022 15:37
@MonikaCat MonikaCat added the automerge Automatically merge PR once all prerequisites pass label Mar 17, 2022
go.mod Outdated Show resolved Hide resolved
@RiccardoM RiccardoM changed the title fix: run bdjuno parse-genesis cmd without accessing the node build(deps): bump forbole/juno to v3.0.0 Mar 31, 2022
Copy link
Contributor

@RiccardoM RiccardoM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@huichiaotsou
Copy link
Contributor

should we modify the schema in 00-cosmos.sql to support table partitioning?

@RiccardoM
Copy link
Contributor

should we modify the schema in 00-cosmos.sql to support table partitioning?

Yes we should update all the necessary SQL schemes that have been updated inside Juno 3.0.0

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (v2/cosmos/stargate@38f0149). Click here to learn what that means.
The diff coverage is n/a.

@@                  Coverage Diff                  @@
##             v2/cosmos/stargate     #356   +/-   ##
=====================================================
  Coverage                      ?   57.58%           
=====================================================
  Files                         ?       17           
  Lines                         ?     1339           
  Branches                      ?        0           
=====================================================
  Hits                          ?      771           
  Misses                        ?      472           
  Partials                      ?       96           

Copy link
Contributor

@huichiaotsou huichiaotsou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested Ack

@mergify mergify bot merged commit 5e6619a into v2/cosmos/stargate Apr 1, 2022
@mergify mergify bot deleted the monika/update-parse-genesis-cmd branch April 1, 2022 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Automatically merge PR once all prerequisites pass
Projects
None yet
4 participants