-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature Request : Use the new Context API #194
Comments
This is now our most 👍'd issue! For those who find this issue, @ThibautMarechal is working on a PR here: #198 |
@rkuykendall I have just an issue, If we use the new context api, it means that Formsy must be a PeerDependencies. |
I will not lie and say I understand this issue very well. I did have a similar problem with another library, where moving a shared dependency to peer fixed a shared state issue, but that seems like a concern for other libraries? It seems reasonable to me to have to install another library that adds components alongside formsy and not instead of formsy. |
Thanks for closing! This will be released with Formsy 2.0.1 either today or tomorrow morning :) |
Released: v2.0.1
|
For now Formsy use the legacy context api. (https://reactjs.org/docs/legacy-context.html)
We should use the new context api. (https://reactjs.org/docs/context.html)
So we don't have warnings when running in strict-mode.
The text was updated successfully, but these errors were encountered: