Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore HTTP Keep-alives #28

Closed
lawrencegripper opened this issue Oct 22, 2018 · 0 comments
Closed

Ignore HTTP Keep-alives #28

lawrencegripper opened this issue Oct 22, 2018 · 0 comments

Comments

@lawrencegripper
Copy link
Contributor

As per the change in Cockroach leaktest I'd like to ignore HTTP keep-alives in this utility.

leaktest: ignore HTTP keep alives
Tests that performed an HTTP connection using the default client had to
have a special instruction to poke http.DefaultClient to disable keep
alives to prevent the leaktester from failing. An upcoming change performs
an HTTP connection with its own unconfigurable client, which would have
required a bunch of special code just to make the leak tester pass.
Instead, ignore stacks that are included during a connection in keep
alive. This matches the code in net/http/main_test.go#afterTest.

cockroachdb/cockroach@e5e6dde#diff-fdc7f75e12e2453349457c6742ff532f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant